feat: add L2 gas estimate on v2, as well as enable Arbitrum on v2 support #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsy1218
changed the title
jsy1218
changed the title
jsy1218
force-pushed
the
jsy1218/enable-arbitrum-on-v2
branch
from
714f1ff to
97a983e
Compare
mikeki
reviewed
Feb 9, 2024
mikeki
approved these changes
Feb 9, 2024
Exactly, @zhongeric agreed to review as well |
zhongeric
reviewed
Feb 12, 2024
src/routers/alpha-router/gas-models/v2/v2-heuristic-gas-model.ts
Outdated
Show resolved
Hide resolved
zhongeric
reviewed
Feb 13, 2024
zhongeric
approved these changes
Feb 13, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)
We disabled arbitrum v2 support. Also we don't have any gas model for L2 on v2.
What is the new behavior (if this is a feature change)?
We are enabling arbitrum v2 support. Also the USDC/WETH pool on arbitrum uses native USDC, so we are adding that support. And then we are able to implement the gas model for L2 on v2.
Other information:
Also added the USDC/WETH on arbitrum for V2 only integ-test