fix: NetworkTransform half float synch (#2791)

NoelStephensUnity · web-flow · commit 53b735c70fba · 2023-12-13T20:31:27.000Z
* fix

Fixing the issue with HalfFloat position not keeping the base position synchronized when using unreliable deltas.
diff --git a/com.unity.netcode.gameobjects/Components/NetworkTransform.cs b/com.unity.netcode.gameobjects/Components/NetworkTransform.cs
@@ -1857,7 +1857,8 @@ private bool ApplyTransformToNetworkStateWithInfo(ref NetworkTransformState netw
 
                         networkState.NetworkDeltaPosition = m_HalfPositionState;
 
-                        if (m_HalfFloatTargetTickOwnership > m_CachedNetworkManager.ServerTime.Tick && !networkState.IsTeleportingNextFrame)
+                        // If ownership offset is greater or we are doing an axial synchronization then synchronize the base position 
+                        if ((m_HalfFloatTargetTickOwnership > m_CachedNetworkManager.ServerTime.Tick || isAxisSync) && !networkState.IsTeleportingNextFrame)
                         {
                             networkState.SynchronizeBaseHalfFloat = true;
                         }

Original file line number	Diff line number	Diff line change
`@@ -1857,7 +1857,8 @@ private bool ApplyTransformToNetworkStateWithInfo(ref NetworkTransformState netw`
`1857`	`1857`
`1858`	`1858`	`networkState.NetworkDeltaPosition = m_HalfPositionState;`
`1859`	`1859`
`1860`		`- if (m_HalfFloatTargetTickOwnership > m_CachedNetworkManager.ServerTime.Tick && !networkState.IsTeleportingNextFrame)`
	`1860`	`+ // If ownership offset is greater or we are doing an axial synchronization then synchronize the base position`
	`1861`	`+ if ((m_HalfFloatTargetTickOwnership > m_CachedNetworkManager.ServerTime.Tick \|\| isAxisSync) && !networkState.IsTeleportingNextFrame)`
`1861`	`1862`	`{`
`1862`	`1863`	`networkState.SynchronizeBaseHalfFloat = true;`
`1863`	`1864`	`}`