Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate NetworkTransform away from using named messages over to NetworkTransformMessage [MTT-7535] #2810

Merged
merged 8 commits into from
Jan 17, 2024
Merged

chore: migrate NetworkTransform away from using named messages over to NetworkTransformMessage [MTT-7535] #2810

merged 8 commits into from
Jan 17, 2024

Conversation

NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented Jan 12, 2024 •
edited
Loading

This PR implements an internal NetworkTransformMessage that NetworkTransform will now use as opposed to using named messages. For future feature compatibility purposes.

MTT-7535

Changelog

  • Changed: NetworkTransform now uses NetworkTransformMessage as opposed to named messages for NetworkTransformState updates.

Testing and Documentation

  • No tests have been added.
  • No documentation changes or additions were necessary.

@NoelStephensUnity
update
cd01679 
Adding the NetworkTransformMessage
@NoelStephensUnity
update
e4645db 
Expanding INetworkMessgeILPP assembly processing to Unity.Netcode.Components.
@NoelStephensUnity
style
72d2ff3 
removing unused namespace.
@NoelStephensUnity
style
84ae352 
Fixed imports ordering.
@NoelStephensUnity
update
c6d9330 
adding changelog entry
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review January 12, 2024 22:49
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner January 12, 2024 22:49
@NoelStephensUnity
update
d237be0 
removing the INetworkSerializeByMemcpy interface.
@NoelStephensUnity
update
ec60ec2 
avoiding a memcpy and adding additional comments for clarity.
@NoelStephensUnity NoelStephensUnity enabled auto-merge (squash) January 16, 2024 20:26
@NoelStephensUnity NoelStephensUnity merged commit adcec18 into develop Jan 17, 2024
23 checks passed
@NoelStephensUnity NoelStephensUnity deleted the chore/migrate-networktransform-namedmessage-to-internalmessage-mtt-7535- branch January 17, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShadauxCat ShadauxCat ShadauxCat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NoelStephensUnity @ShadauxCat