test: metrics counting

Author: kwasniew

src/test/client.test.ts

@@ -14,7 +14,7 @@ test('should add environment to isEnabled calls', () => {
 
     config.disableMetrics = true;
 
-    const client = createFakeClient(config);
+    const { client } = createFakeClient(config);
 
     const fakeUnleash = client.unleash as FakeUnleash;
 
@@ -46,7 +46,7 @@ test('should override environment to isEnabled calls', () => {
 
     config.disableMetrics = true;
 
-    const client = createFakeClient(config);
+    const { client } = createFakeClient(config);
 
     const fakeUnleash = client.unleash as FakeUnleash;
 
@@ -78,7 +78,7 @@ test('should return all toggles', () => {
 
     config.disableMetrics = true;
 
-    const client = createFakeClient(config);
+    const { client } = createFakeClient(config);
 
     const fakeUnleash = client.unleash as FakeUnleash;
 
@@ -132,7 +132,7 @@ test('should return default variant for disabled toggles', () => {
 
     config.disableMetrics = true;
 
-    const client = createFakeClient(config);
+    const { client } = createFakeClient(config);
 
     const fakeUnleash = client.unleash as FakeUnleash;
 
@@ -180,3 +180,40 @@ test('should return default variant for disabled toggles', () => {
     expect(result[2].variant?.enabled).toBe(false);
     client.destroy();
 });
+
+test('should register metrics', () => {
+    const config = createProxyConfig({
+        unleashApiToken: '123',
+        unleashUrl: 'http://localhost:4242/api',
+        proxySecrets: ['s1'],
+        environment: 'never-change-me',
+        logLevel: LogLevel.error,
+    });
+
+    const { client, metrics } = createFakeClient(config);
+
+    client.registerMetrics({
+        bucket: {
+            toggles: {
+                toggle: {
+                    yes: 3,
+                    no: 1,
+                    variants: { variantA: 2, variantB: 1, disabled: 1 },
+                },
+            },
+        },
+    });
+
+    expect(metrics.recordedCount).toStrictEqual([
+        ['toggle', true],
+        ['toggle', true],
+        ['toggle', true],
+        ['toggle', false],
+    ]);
+    expect(metrics.recordedCountVariant).toStrictEqual([
+        ['toggle', 'variantA'],
+        ['toggle', 'variantA'],
+        ['toggle', 'variantB'],
+        ['toggle', 'disabled'],
+    ]);
+});

src/test/create-fake-client.ts

@@ -4,7 +4,9 @@ import { defaultStrategies } from 'unleash-client/lib/strategy';
 import FakeUnleash from './unleash.mock';
 import FakeMetrics from './metrics.mock';
 
-export const createFakeClient = (config: IProxyConfig): Client => {
+export const createFakeClient = (
+    config: IProxyConfig,
+): { client: Client; metrics: FakeMetrics } => {
     const unleash = new FakeUnleash({
         ...config,
         url: config.unleashUrl,
@@ -19,5 +21,7 @@ export const createFakeClient = (config: IProxyConfig): Client => {
         strategies: defaultStrategies.map((s) => s.name),
     });
 
-    return new Client(config, unleash, metrics);
+    const client = new Client(config, unleash, metrics);
+
+    return { client, metrics };
 };

src/test/metrics.mock.ts

@@ -1,17 +1,23 @@
 /* eslint-disable @typescript-eslint/explicit-module-boundary-types */
 
-/* eslint-disable @typescript-eslint/no-unused-vars */
-
 import Metrics from 'unleash-client/lib/metrics';
 
 class FakeMetrics extends Metrics {
+    recordedCount: [string, boolean][] = [];
+
+    recordedCountVariant: [string, string][] = [];
+
     start() {}
 
-    count(name: string, enabled: boolean) {}
+    count(name: string, enabled: boolean) {
+        this.recordedCount.push([name, enabled]);
+    }
 
-    countVariant(name: string, variantName: string) {}
+    countVariant(name: string, variantName: string) {
+        this.recordedCountVariant.push([name, variantName]);
+    }
 
-    on(eventName: string | symbol, listener: (...args: any[]) => void): this {
+    on(): this {
         return this;
     }
 }