-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
observability into refreshes #187
Comments
Hi @nicks . Thank you for your report. By default, the proxy is setup to log errors if any happen, so if you're seeing a quiet log, it should mean you're not having a refreshing issue. From our client constructor this.metrics.on('error', (msg) => this.logger.error(`metrics: ${msg}`));
this.unleash.on('error', (msg) => this.logger.error(msg)); We could add two prometheus gauges, Unless you're using custom strategies or context enrichers, we do recommend swapping to Unleash Edge (https://github.com/unleash/unleash-edge) where we have an endpoint allowing you to see the status of all client keys being used. |
Reported in #187, this PR adds prometheus and creates two gauges, one for keeping track of last update (an actual refresh of feature toggles) as well as last call to upstream Unleash. sidenote: moved to biome and copied Unleash/unleash config to fall more in line, should've been a separate PR, but once I got stuck into adding prometheus, I couldn't help myself, I had to boyscout
Adds prometheus gauges for when we last fetched (no matter if 200 or 304) and when we last updated (only updated when status==200) Fixes: #187
Added and released as v1.4.5 of the proxy, which should be available in the coming 20 minutes or so. |
Copying from the README what we added.
|
Describe the feature request
is there a way to get observability into how the proxy is refreshing?
Background
we had an incident a month ago where we thought it might be related to refreshing, and there wasn't an easy way to tell from the outside when the last time the proxy had refreshed its data
Solution suggestions
Logs would be fine (there are very few logs right now)
A prometheus-style metrics endpoint would also work.
The text was updated successfully, but these errors were encountered: