feat: Export last check and last update to prometheus #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reported in #187, this PR adds prometheus and creates two gauges, one for keeping track of last update (an actual refresh of feature toggles) as well as last call to upstream Unleash. sidenote: moved to biome and copied Unleash/unleash config to fall more in line, should've been a separate PR, but once I got stuck into adding prometheus, I couldn't help myself, I had to boyscout
chriswk
commented
Aug 1, 2024
Comment on lines
+9
to
+22
| export const lastMetricsUpdate: Gauge = createGauge({ | ||
| name: 'last_metrics_update_epoch_timestamp_ms', | ||
| help: 'An epoch timestamp (in milliseconds) set to when our unleash-client last got an update from upstream Unleash', | ||
| }); | ||
|
|
||
| export const lastMetricsFetch: Gauge = createGauge({ | ||
| name: 'last_metrics_fetch_epoch_timestamp_ms', | ||
| help: 'An epoch timestamp (in milliseconds) set to when our unleash-client last checked (regardless if there was an update or not)', | ||
| }); | ||
|
|
||
| createCounter({ | ||
| name: 'unleash_proxy_up', | ||
| help: 'Indication that the service is up.', | ||
| }).inc(1); |
There was a problem hiding this comment.
The gist of the PR is here. Copies Nuno's great work on creating typechecked labels (though we don't actually use labels here) from unleash/unleash, but sets up for the future. Could consider removing histogram and summary, since it's currently unused.
chriswk
commented
Aug 1, 2024
Comment on lines
+82
to
90
| this.unleash.on(UnleashEvents.Unchanged, () => { | ||
| lastMetricsFetch.set(new Date().getTime()); | ||
| }); | ||
| this.unleash.on(UnleashEvents.Changed, () => { | ||
| const updated = new Date().getTime(); | ||
| lastMetricsFetch.set(updated); | ||
| lastMetricsUpdate.set(updated); | ||
| }); | ||
| } |
There was a problem hiding this comment.
Other important behavior change, adds an event listener to Unchanged updating the fetch counter, and to Changed events updating both last fetch and last update.
|
F this. Will remake PR without the linting, and make a separate PR with those changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported in #187, this PR adds prometheus and creates two gauges, one for keeping track of last update (an actual refresh of feature toggles) as well as last call to upstream Unleash.
sidenote: moved to biome and copied Unleash/unleash config to fall more in line, should've been a separate PR, but once I got stuck into adding prometheus, I couldn't help myself, I had to boyscout
2nd sidenote: We really should boyscout this a bit more, we're still using node 16, our nvmrc was locked to node 14, and we should move to yarn v4 here as well. Separate PR for that at least.