Skip to content

Fix defaultProps warning from recharts #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jtucholski opened this issue Oct 7, 2024 · 2 comments
Open

Fix defaultProps warning from recharts #414

jtucholski opened this issue Oct 7, 2024 · 2 comments
Labels
dependencies Pull requests that update a dependency file frontend technical debt

Comments

@jtucholski
Copy link
Contributor

Recharts currently throws the following warning due to a future release that will remove defaultProps.

Warning: XAxis: Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead.

We should update the components that use recharts to not use defaultProps. You can find these warnings on any of the pages that recharts graphs are used. For example, in AdminDashboard.tsx and StudentDashboard.tsx.

@jtucholski
Copy link
Contributor Author

This is similar to this issue posted on recharts: recharts/recharts#3615 (comment)

@jtucholski
Copy link
Contributor Author

It looks like bumping the version of recharts up to 2.13 resolves these warnings. The fix here is to verify we can bump our version in our codebase and make sure that it doesn't break anything else in the process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file frontend technical debt
Projects
None yet
Development

No branches or pull requests

1 participant