From 05bbbd2366861024f5ca938fc9e65f2786071524 Mon Sep 17 00:00:00 2001 From: Richardas Kuchinskas Date: Sun, 16 Feb 2025 22:08:17 +0300 Subject: [PATCH] Removed comments --- src/linter/block.go | 5 ----- src/tests/checkers/null_safety_test.go | 1 + 2 files changed, 1 insertion(+), 5 deletions(-) create mode 100644 src/tests/checkers/null_safety_test.go diff --git a/src/linter/block.go b/src/linter/block.go index 6cba9b4d..2e81e01f 100644 --- a/src/linter/block.go +++ b/src/linter/block.go @@ -1122,7 +1122,6 @@ func (b *blockWalker) checkConstFetchNullSafety(arg ir.Node, fn meta.FuncInfo, p } } -// TODO: we don't know type of each element without phpDoc, it will be mixed func (b *blockWalker) checkArrayDimFetchNullSafety(arg ir.Node, fn meta.FuncInfo, paramIndex int, arrayExpr *ir.ArrayDimFetchExpr, haveVariadic bool) { baseVar, ok := arrayExpr.Variable.(*ir.SimpleVar) if !ok { @@ -1156,14 +1155,12 @@ func (b *blockWalker) checkArrayDimFetchNullSafety(arg ir.Node, fn meta.FuncInfo } } -// TODO: we don't know type of each element without phpDoc, it will be mixed func (b *blockWalker) checkListExprNullSafety(arg ir.Node, fn meta.FuncInfo, paramIndex int, listExpr *ir.ListExpr, haveVariadic bool) { for _, item := range listExpr.Items { if item == nil { continue } - // Если в элементе списка есть ключ, проверяем его рекурсивно. if item.Key != nil { b.checkNullSafetyCallArgsF([]ir.Node{item.Key}, fn) } @@ -1177,7 +1174,6 @@ func (b *blockWalker) checkListExprNullSafety(arg ir.Node, fn meta.FuncInfo, par effectiveParam = fn.Params[paramIndex] } - // Если значение элемента является простой переменной, проверяем её тип. if simpleVar, ok := item.Val.(*ir.SimpleVar); ok { varInfo, found := b.ctx.sc.GetVar(simpleVar) if found && types.IsTypeNullable(varInfo.Type) { @@ -1189,7 +1185,6 @@ func (b *blockWalker) checkListExprNullSafety(arg ir.Node, fn meta.FuncInfo, par } } - // Рекурсивно проверяем само выражение значения элемента списка. b.checkNullSafetyCallArgsF([]ir.Node{item.Val}, fn) } } diff --git a/src/tests/checkers/null_safety_test.go b/src/tests/checkers/null_safety_test.go new file mode 100644 index 00000000..d0ae62bb --- /dev/null +++ b/src/tests/checkers/null_safety_test.go @@ -0,0 +1 @@ +package checkers