linter: expanded deprecated for calling const, property and instances of classes #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hidanio
force-pushed
the
hidanio/deprecated_calls
branch
3 times, most recently
from
9b6d7b5 to
82a5b14
Compare
Hidanio
changed the title
Hidanio
force-pushed
the
hidanio/deprecated_calls
branch
from
82a5b14 to
27506c0
Compare
|
Level notice for deprecated and deprecatedUntagged |
Hidanio
force-pushed
the
hidanio/deprecated_calls
branch
from
27506c0 to
2ff400c
Compare
DrDet
approved these changes
Feb 27, 2025
Hidanio
force-pushed
the
hidanio/deprecated_calls
branch
from
2ff400c to
f21c8de
Compare
DrDet
approved these changes
Mar 6, 2025
| func (d *rootWalker) parsePHPDocVar(doc phpdoc.Comment) (typesMap types.Map) { | ||
| for _, part := range doc.Parsed { | ||
| part, ok := part.(*phpdoc.TypeVarCommentPart) | ||
| func (d *rootWalker) parsePHPDocVar(doc phpdoc.Comment) (typesMap types.Map, deprecationInfo meta.DeprecationInfo) { |
There was a problem hiding this comment.
DeprecationInfo should not be part of parsePHPDocVar, even the function name says that on parses var tag.
There was a problem hiding this comment.
In this case the contex of Var - variable (property). See parseConstPHPDoc, parseClassPHPDoc: in all cases we are parse everything
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we have deprecated and deprecatedUntagged rule that could be apply for methods and functions.
I expanded it for calling const, property and instances of classes