Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: storybooks for all components #76

Merged
merged 5 commits into from
Dec 2, 2024
Merged

feat: storybooks for all components #76

merged 5 commits into from
Dec 2, 2024

Conversation

zintarh
Copy link
Contributor

@zintarh zintarh commented Nov 30, 2024 •
edited
Loading

Description

closes #20

Checklist

  • The title of the PR is clear and descriptive.
  • All tests have been run and passed.
  • Code follows project conventions (Biome formatting, linting).
  • Documentation has been updated as needed.
  • Commit messages follow the Conventional Commits style.

Type of Change

  • Bugfix
  • Feature
  • Refactor
  • Chore
  • Documentation
  • Test

Testing

Manual Testing

Automated Tests

  • Unit tests added or updated
  • Integration tests added or updated
  • E2E tests added or updated

Additional Notes

@vercel Vercel
Copy link

vercel bot commented Nov 30, 2024

@zintarh is attempting to deploy a commit to the CofiBlocks Team on Vercel.

A member of the Team first needs to authorize it.

@zintarh zintarh marked this pull request as draft November 30, 2024 07:48
@zintarh zintarh marked this pull request as ready for review November 30, 2024 13:24
@evgongora evgongora self-requested a review December 1, 2024 19:53
evgongora
evgongora reviewed Dec 1, 2024
View reviewed changes
Copy link
Collaborator

@evgongora evgongora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Can you just add a recorded preview of the storybook so we can have it saved in your PR? :)

@zintarh
Copy link
Contributor Author

zintarh commented Dec 2, 2024 •
edited
Loading

Alright @evgongora

The record is too large, so I uploded it to youtube
https://www.youtube.com/watch?v=IItsq2rVYf4

@evgongora evgongora self-requested a review December 2, 2024 13:58
evgongora
evgongora approved these changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@evgongora evgongora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Thank you so much :)

@evgongora evgongora merged commit 9b19604 into Vagabonds-Labs:main Dec 2, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evgongora evgongora evgongora approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Storybook Configuration and Create Stories for Basic Components in @repo/ui
2 participants
@zintarh @evgongora