Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✔️Added Interactive Smooth "Hover Effects" to The Links in Footer #495

Merged
merged 3 commits into from
Jul 25, 2024

Conversation

aslams2020
Copy link
Contributor

Hey @VaibhavArora314
issue closes #493

I have added the Smooth hovering effects for all the links in the footer section.

Here's the Implementation :

styleshare.hover.mp4

Please take a look.
Thankyou!

Copy link

vercel bot commented Jul 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
style-share ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2024 5:53pm

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link
Owner

@VaibhavArora314 VaibhavArora314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just 2 changes:

  1. Remove package-lock.json from root of repo
  2. Don't do plain CSS styling use tailwind to maintain consistency as much as possible, try apply if u want to do in external CSS file

@aslams2020
Copy link
Contributor Author

Hey @VaibhavArora314 @akbatra567
I'm unable to make these hovering changes into Tailwind they are not displaying the required output, Is it ok to let it be as it is as external css?
Also, I removed the package-lock.json.

@VaibhavArora314
Copy link
Owner

Hey @VaibhavArora314 @akbatra567
I'm unable to make these hovering changes into Tailwind they are not displaying the required output, Is it ok to let it be as it is as external css?
Also, I removed the package-lock.json.

Ok then leave it as it is, rest is okay with me.

@akbatra567
Copy link
Collaborator

Hey @VaibhavArora314 @akbatra567
I'm unable to make these hovering changes into Tailwind they are not displaying the required output, Is it ok to let it be as it is as external css?
Also, I removed the package-lock.json.

Try experimenting a bit on what all we can do with current capabilities of tailwind. Too much customization might not be possible. See if you can refer some parts of documentation and are able to reproduce a similar effect.
Else if there is a possibility of creating a custom tailwind class - [could be a great learning experience]

Some links to refer:

https://tailwindcss.com/docs/text-decoration
https://tailwindcss.com/docs/hover-focus-and-other-states
https://tailwindcss.com/docs/gradient-color-stops

@aslams2020
Copy link
Contributor Author

@akbatra567 Thanks for responding! I will try once again with this

@Ultimateutkarsh11 Ultimateutkarsh11 merged commit 3b7cefc into VaibhavArora314:main Jul 25, 2024
3 checks passed
Copy link

🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc GSSOC level1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨Styling : Adding Interactive Smooth "Hover Effects" to The Links in Footer
4 participants