-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cropper empty space #444
Comments
This is not a bug but the expected behaviour. What would you expect instead of this? |
Its shoud auto zoom in photo so that it fills the empty space in photos and prevent any empty spaces while rotating. You can check other editors for reference. |
I see your point. The behaviour you expect could be added as a new option (that could be defaulted to "no empty space" in a future major version). That being said, we need to implement the logic to automatically set the right zoom level based on the rotation. This is not trivial and requires some math/geometry investigation. Are you willing to have a look into this and create a PR? |
Given position and rotation of image, we can calculate the min scale ensure the boundary of image and canvas have no intersections. |
Trim the blank image and there will be nothing in the image that will be trimmed on the browser of the iOS phone. |
Describe the bug
While rotating image its showing the empty spaces inside the cropper.
The text was updated successfully, but these errors were encountered: