Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat:Want to Update Canteen Cards #398 #411

Merged
merged 1 commit into from
Jul 7, 2024

Conversation

nishant0708
Copy link
Contributor

  1. Made Card Responsive
  2. Assigned Fixed Width And Height to cards and handled them according to screen size to ensure responsiveness
  3. Fixed Canteen Image Overflowing issue
  4. Handled Condition Where Canteen has Big Name

Fixes #398

Type of change

Please mark with an X the type that applies:

  • Bug fix (non-breaking change which fixes an issue)
  • [ X] New feature (non-breaking change which adds functionality)
  • Refactor code
  • Documentation update
  • Other (mentioned in the issue number)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce them. Please also list any relevant details for your test configuration.

Test A: Describe here

Test B: Describe here (if required)

Screenshots and Videos

Screenshot 2024-07-04 052928
Screenshot 2024-07-04 053229

Please provide screenshots and videos of the changes you made.

Checklist

Please mark with an X the items that apply:

  • [ X] My code follows the style guidelines of this project
  • [ X] I have performed a self-review of my code
  • [X ] I have commented my code, particularly in hard-to-understand areas
  • [ X] I have made corresponding changes to the documentation
  • [X ] My changes generate no new warnings
  • [X ] I have added tests that prove my fix is effective or that my feature works
  • [X ] New and existing unit tests pass locally with my changes
  • [X ] Any dependent changes have been merged and published in downstream modules

Copy link

vercel bot commented Jul 4, 2024

@nishant0708 is attempting to deploy a commit to the vansh69's projects Team on Vercel.

A member of the Team first needs to authorize it.

@nishant0708
Copy link
Contributor Author

hey @hustlerZzZ it would be great if you could assign it level 2

@hustlerZzZ hustlerZzZ added gssoc This label is attached to the issues related to Gssoc'24 level1 labels Jul 7, 2024
@hustlerZzZ hustlerZzZ merged commit 14a9103 into VanshKing30:main Jul 7, 2024
1 of 2 checks passed
Copy link

github-actions bot commented Jul 7, 2024

Congratulations, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to the project 🚀 Keep Contributing!! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc This label is attached to the issues related to Gssoc'24 level1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat:Want to Update Canteen Cards
2 participants