Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat:Error in updating Food items from Canteen End + This should be in Cards #434 #449

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

nishant0708
Copy link
Contributor

@nishant0708 nishant0708 commented Jul 18, 2024

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #434

  1. Fixed Updation Logic
  2. Converted Ui To Cards
  3. Made Sure Canteen End Cant Edit food Item
  4. Removed Unecesarry Code
  5. optimzed Solution

Actually SomeOne Handled Merge Conflics Wrongly so There was Both Old and new Code So Fixed That

Type of change

Screenshot 2024-07-19 022256
Screenshot 2024-07-19 022304

Please mark with an X the type that applies:

  • [X ] Bug fix (non-breaking change which fixes an issue)
  • [ X] New feature (non-breaking change which adds functionality)
  • [X ] Refactor code
  • [X ] Documentation update
  • [X ] Other (mentioned in the issue number)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce them. Please also list any relevant details for your test configuration.

Test A: Describe here

Test B: Describe here (if required)

Screenshots and Videos

Please provide screenshots and videos of the changes you made.

Checklist

Please mark with an X the items that apply:

  • [X ] My code follows the style guidelines of this project
  • [ X] I have performed a self-review of my code
  • [X ] I have commented my code, particularly in hard-to-understand areas
  • [X ] I have made corresponding changes to the documentation
  • [X ] My changes generate no new warnings
  • [ X] I have added tests that prove my fix is effective or that my feature works
  • [X ] New and existing unit tests pass locally with my changes
  • [X ] Any dependent changes have been merged and published in downstream modules

Copy link

vercel bot commented Jul 18, 2024

@nishant0708 is attempting to deploy a commit to the vansh69's projects Team on Vercel.

A member of the Team first needs to authorize it.

@hustlerZzZ hustlerZzZ added gssoc This label is attached to the issues related to Gssoc'24 level2 labels Jul 24, 2024
Copy link
Collaborator

@hustlerZzZ hustlerZzZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work

@hustlerZzZ hustlerZzZ merged commit 7a4c211 into VanshKing30:main Jul 24, 2024
1 of 2 checks passed
Copy link

Congratulations, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to the project 🚀 Keep Contributing!! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc This label is attached to the issues related to Gssoc'24 level2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat:Error in updating Food items from Canteen End + This should be in Cards
2 participants