-
Notifications
You must be signed in to change notification settings - Fork 2
[PLAT-5255] Update openapi and update to latest #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Also now using all but 5 generated source files.
RE> "The metadata values doesn't have a enum type for the "type" like a "long" or "float" type and that makes the auto-generated source ignore and value for the type. There is a small modification made to the auto generated to match on the type string and also on the values." Why is this only true for metadata types and not all of the other any ofs that we have? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, if you've tested the anyof mappings to verify those are working.
OneOfWebhookEventSceneIncludedDataWebhookEventPartRevisionIncludedData.java \ | ||
OneOfUpdateItemToDefaultRenditionOperation.java \ | ||
OneOfSceneViewRelationshipSceneViewStateRelationship.java \ | ||
AnyOfFileRelationshipPartAssemblyRelationship.java ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is it that only the Metadata types are added here? Do we need to maintain all of these AnyOf relationships?
package com.vertexvis.example; | ||
|
||
import com.vertexvis.model.QueuedJob; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are all of these examples removed. IIRC, these were added so clients could reference these as to how to use the platform with the java client.
|
This is still work in progress. To build this, you need to add the following change to
vertex-api/src/universal/api.yml
Summary
This updates the API-Client to a major version 1.0.0 since this is a big breaking change.
This is a major update as it upgraded the openapi generator to version 7.11.0. This version will produce all the OneOf and AnyOf classes so there are no manual generation of java classes except one type: metadata values.
The metadata values doesn't have a enum type for the "type" like a "long" or "float" type and that makes the auto-generated source ignore and value for the type. There is a small modification made to the auto generated to match on the type string and also on the values.
Test Plan
Using test and clients using the library.
Release Notes
Not sure how we would indicate the breaking changes.
Possible Regressions
Not know at this point.