refactor: extract magic var

Author: VincentHardouin

src/domain/usecases/HandleNewReservationUseCase.js

@@ -2,6 +2,8 @@ import { reservationRepository } from '../../infrastructure/ReservationRepositor
 import { NotFoundError } from '../NotFoundError.js';
 import { Reservation } from '../Reservation.js';
 
+const CODE_REGEXP = /Voici votre code de réservation UCPA : (?<code>\d+)/;
+
 export class HandleNewReservationUseCase {
   constructor({ imapClient, searchQuery }) {
     this.imapClient = imapClient;
@@ -20,7 +22,7 @@ export class HandleNewReservationUseCase {
   }
 
   _getUCPAReservationCode(message) {
-    const match = message.html.match(/Voici votre code de réservation UCPA : (?<code>\d+)/);
+    const match = message.html.match(CODE_REGEXP);
     if (!match) {
       return null;
     }

src/domain/usecases/HandleScheduledReservationUseCase.js

@@ -1,6 +1,10 @@
 import { NotFoundError } from '../NotFoundError.js';
 import { Reservation } from '../Reservation.js';
 
+const RESERVATION_ACCEPTED_MESSAGE_CONTENT = 'MERCI POUR VOTRE RESERVATION !';
+const EXTRACT_INFORMATION_REGEXP = /Terrain (?<court>\d+) (?<activity>\w+)\s\w+ le (?<date>\d{2}-\d{2}-\d{4}) à (?<hour>\d{2}:\d{2})/;
+const EXTRACT_CODE_REGEXP = /<p>(?<code>\d+)<\/p>/;
+
 export class HandleScheduledReservationUseCase {
   constructor({ imapClient, searchQuery, reservationRepository }) {
     this.imapClient = imapClient;
@@ -11,7 +15,7 @@ export class HandleScheduledReservationUseCase {
   async execute() {
     const messages = await this.imapClient.fetch(this.searchQuery);
     for (const message of messages) {
-      const isScheduledReservationMessage = message.html.includes('MERCI POUR VOTRE RESERVATION !');
+      const isScheduledReservationMessage = message.html.includes(RESERVATION_ACCEPTED_MESSAGE_CONTENT);
       if (!isScheduledReservationMessage) {
         continue;
       }
@@ -24,12 +28,12 @@ export class HandleScheduledReservationUseCase {
   }
 
   _getInformation(message) {
-    const match = message.html.match(/Terrain (?<court>\d+) (?<activity>\w+)\s\w+ le (?<date>\d{2}-\d{2}-\d{4}) à (?<hour>\d{2}:\d{2})/);
+    const match = message.html.match(EXTRACT_INFORMATION_REGEXP);
     if (!match) {
       return null;
     }
 
-    const matchCode = message.html.match(/<p>(?<code>\d+)<\/p>/);
+    const matchCode = message.html.match(EXTRACT_CODE_REGEXP);
     if (!matchCode) {
       return null;
     }

src/infrastructure/TimeSlotDatasource.js

@@ -1,14 +1,16 @@
 import { TimeSlot } from '../domain/TimeSlot.js';
 import { httpClient } from './HttpClient.js';
 
+const USER_AGENT = 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:127.0) Gecko/20100101 Firefox/127.0';
+
 export class TimeSlotDatasource {
   async getAllAvailable(areaId) {
     const requests = [
       getDatePlusDays(0),
       getDatePlusDays(7),
       getDatePlusDays(14),
     ].map(async (date) => {
-      return httpClient.get(`https://www.ucpa.com/sport-station/api/areas-offers/weekly/alpha_hp?=&reservationPeriod=1&espace=${areaId}&time=${date}&__amp_source_origin=https://www.ucpa.com`, { 'User-agent': 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:127.0) Gecko/20100101 Firefox/127.0' });
+      return httpClient.get(`https://www.ucpa.com/sport-station/api/areas-offers/weekly/alpha_hp?=&reservationPeriod=1&espace=${areaId}&time=${date}&__amp_source_origin=https://www.ucpa.com`, { 'User-agent': USER_AGENT });
     });
 
     let availableTimeSlots = [];