Refactor serilog initialization and add module initialization logging #1238
Annotations
10 warnings
|
Build
/home/runner/work/vc-platform/vc-platform/src/VirtoCommerce.Platform.Core/Logger/ConsoleLog.cs(10,13): warning S106: Remove this logging statement. (https://rules.sonarsource.com/csharp/RSPEC-106) [/home/runner/work/vc-platform/vc-platform/src/VirtoCommerce.Platform.Core/VirtoCommerce.Platform.Core.csproj]
|
|
Build
/home/runner/work/vc-platform/vc-platform/src/VirtoCommerce.Platform.Core/Logger/ConsoleLog.cs(15,13): warning S106: Remove this logging statement. (https://rules.sonarsource.com/csharp/RSPEC-106) [/home/runner/work/vc-platform/vc-platform/src/VirtoCommerce.Platform.Core/VirtoCommerce.Platform.Core.csproj]
|
|
Build
/home/runner/work/vc-platform/vc-platform/src/VirtoCommerce.Platform.Modules/ModuleInitializer.cs(94,79): warning S927: Rename parameter 'appBuilder' to 'serviceProvider' to match the interface declaration. (https://rules.sonarsource.com/csharp/RSPEC-927) [/home/runner/work/vc-platform/vc-platform/src/VirtoCommerce.Platform.Modules/VirtoCommerce.Platform.Modules.csproj]
|
|
Build
/home/runner/work/vc-platform/vc-platform/src/VirtoCommerce.Platform.Modules/ModuleManager.cs(96,17): warning S2589: Change this condition so that it does not always evaluate to 'False'. (https://rules.sonarsource.com/csharp/RSPEC-2589) [/home/runner/work/vc-platform/vc-platform/src/VirtoCommerce.Platform.Modules/VirtoCommerce.Platform.Modules.csproj]
|
|
Build
/home/runner/work/vc-platform/vc-platform/src/VirtoCommerce.Platform.Modules/ModuleManager.cs(106,85): warning S927: Rename parameter 'applicationBuilder' to 'appBuilder' to match the interface declaration. (https://rules.sonarsource.com/csharp/RSPEC-927) [/home/runner/work/vc-platform/vc-platform/src/VirtoCommerce.Platform.Modules/VirtoCommerce.Platform.Modules.csproj]
|
|
Build
/home/runner/work/vc-platform/vc-platform/src/VirtoCommerce.Platform.Modules/ModuleManager.cs(108,13): warning S121: Add curly braces around the nested statement(s) in this 'if' block. (https://rules.sonarsource.com/csharp/RSPEC-121) [/home/runner/work/vc-platform/vc-platform/src/VirtoCommerce.Platform.Modules/VirtoCommerce.Platform.Modules.csproj]
|
|
Build
/home/runner/work/vc-platform/vc-platform/src/VirtoCommerce.Platform.Modules/ModuleManager.cs(292,13): warning S121: Add curly braces around the nested statement(s) in this 'if' block. (https://rules.sonarsource.com/csharp/RSPEC-121) [/home/runner/work/vc-platform/vc-platform/src/VirtoCommerce.Platform.Modules/VirtoCommerce.Platform.Modules.csproj]
|
|
Build
/home/runner/work/vc-platform/vc-platform/src/VirtoCommerce.Platform.Modules/ModuleManager.cs(322,54): warning S3267: Loops should be simplified using the "Where" LINQ method (https://rules.sonarsource.com/csharp/RSPEC-3267) [/home/runner/work/vc-platform/vc-platform/src/VirtoCommerce.Platform.Modules/VirtoCommerce.Platform.Modules.csproj]
|
|
Build
/home/runner/work/vc-platform/vc-platform/src/VirtoCommerce.Platform.Data.SqlServer/Migrations/Data/20190625133326_RemoveDynamicPropertyObjectValue.cs(10,13): warning S125: Remove this commented out code. (https://rules.sonarsource.com/csharp/RSPEC-125) [/home/runner/work/vc-platform/vc-platform/src/VirtoCommerce.Platform.Data.SqlServer/VirtoCommerce.Platform.Data.SqlServer.csproj]
|
|
Build
/home/runner/work/vc-platform/vc-platform/src/VirtoCommerce.Platform.Data.SqlServer/Migrations/Security/20000000000000_UpdateSecurityV2.cs(7,33): warning S138: This method 'Up' has 198 lines, which is greater than the 80 lines authorized. Split it into smaller methods. (https://rules.sonarsource.com/csharp/RSPEC-138) [/home/runner/work/vc-platform/vc-platform/src/VirtoCommerce.Platform.Data.SqlServer/VirtoCommerce.Platform.Data.SqlServer.csproj]
|
Loading