Skip to content

Commit 449cf5e

Browse files
VCST-1592: Fix external sign in after updating OpenIddict (#2843)
1 parent 12dfd1d commit 449cf5e

File tree

4 files changed

+22
-18
lines changed

4 files changed

+22
-18
lines changed

module.ignore

+17-12
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,11 @@ Azure.Messaging.EventGrid.dll
55
Azure.Security.KeyVault.Secrets.dll
66
Dapper.dll
77
DnsClient.dll
8-
dotnet-swagger.dll
98
EntityFrameworkCore.Triggers.dll
109
FluentValidation.dll
1110
Hangfire.AspNetCore.dll
1211
Hangfire.Console.dll
1312
Hangfire.Core.dll
14-
Hangfire.Core.resources.dll
1513
Hangfire.MemoryStorage.dll
1614
Hangfire.MySql.dll
1715
Hangfire.NetCore.dll
@@ -36,9 +34,6 @@ Microsoft.AspNetCore.Identity.EntityFrameworkCore.dll
3634
Microsoft.AspNetCore.JsonPatch.dll
3735
Microsoft.AspNetCore.Metadata.dll
3836
Microsoft.AspNetCore.Mvc.NewtonsoftJson.dll
39-
Microsoft.AspNetCore.Server.Kestrel.Https.dll
40-
Microsoft.AspNetCore.Server.Kestrel.Transport.Abstractions.dll
41-
Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.dll
4237
Microsoft.AspNetCore.SignalR.Client.Core.dll
4338
Microsoft.AspNetCore.SignalR.Client.dll
4439
Microsoft.AspNetCore.SignalR.Common.dll
@@ -50,6 +45,7 @@ Microsoft.Azure.SignalR.Common.dll
5045
Microsoft.Azure.SignalR.dll
5146
Microsoft.Azure.SignalR.Protocols.dll
5247
Microsoft.Bcl.AsyncInterfaces.dll
48+
Microsoft.Bcl.TimeProvider.dll
5349
Microsoft.CodeAnalysis.CSharp.dll
5450
Microsoft.CodeAnalysis.CSharp.resources.dll
5551
Microsoft.CodeAnalysis.CSharp.Workspaces.dll
@@ -66,20 +62,28 @@ Microsoft.EntityFrameworkCore.Design.dll
6662
Microsoft.EntityFrameworkCore.dll
6763
Microsoft.EntityFrameworkCore.Relational.dll
6864
Microsoft.EntityFrameworkCore.SqlServer.dll
69-
Microsoft.Extensions.Caching.Memory.dll
65+
Microsoft.Extensions.AmbientMetadata.Application.dll
66+
Microsoft.Extensions.Compliance.Abstractions.dll
7067
Microsoft.Extensions.Configuration.AzureAppConfiguration.dll
68+
Microsoft.Extensions.Configuration.Binder.dll
7169
Microsoft.Extensions.DependencyInjection.Abstractions.dll
72-
Microsoft.Extensions.DependencyInjection.dll
70+
Microsoft.Extensions.DependencyInjection.AutoActivation.dll
7371
Microsoft.Extensions.DependencyModel.dll
7472
Microsoft.Extensions.DiagnosticAdapter.dll
73+
Microsoft.Extensions.Diagnostics.ExceptionSummarization.dll
7574
Microsoft.Extensions.Features.dll
75+
Microsoft.Extensions.Http.Diagnostics.dll
7676
Microsoft.Extensions.Http.Polly.dll
77+
Microsoft.Extensions.Http.Resilience.dll
7778
Microsoft.Extensions.Identity.Core.dll
7879
Microsoft.Extensions.Identity.Stores.dll
7980
Microsoft.Extensions.Logging.Abstractions.dll
8081
Microsoft.Extensions.Logging.AzureAppServices.dll
82+
Microsoft.Extensions.ObjectPool.dll
8183
Microsoft.Extensions.Options.dll
82-
Microsoft.Extensions.PlatformAbstractions.dll
84+
Microsoft.Extensions.Resilience.dll
85+
Microsoft.Extensions.Telemetry.Abstractions.dll
86+
Microsoft.Extensions.Telemetry.dll
8387
Microsoft.Identity.Client.dll
8488
Microsoft.Identity.Client.Extensions.Msal.dll
8589
Microsoft.IdentityModel.Abstractions.dll
@@ -88,10 +92,12 @@ Microsoft.IdentityModel.Logging.dll
8892
Microsoft.IdentityModel.Protocols.dll
8993
Microsoft.IdentityModel.Protocols.OpenIdConnect.dll
9094
Microsoft.IdentityModel.Tokens.dll
95+
Microsoft.IdentityModel.Validators.dll
96+
Microsoft.IO.RecyclableMemoryStream.dll
97+
Microsoft.Net.Http.Headers.dll
9198
Microsoft.NET.StringTools.dll
9299
Microsoft.OpenApi.dll
93100
Microsoft.SqlServer.Server.dll
94-
Microsoft.VisualStudio.Web.BrowserLink.dll
95101
Microsoft.Win32.SystemEvents.dll
96102
Mono.TextTemplating.dll
97103
MySqlConnector.dll
@@ -124,7 +130,9 @@ package-lock.json
124130
Pipelines.Sockets.Unofficial.dll
125131
Polly.Core.dll
126132
Polly.dll
133+
Polly.Extensions.dll
127134
Polly.Extensions.Http.dll
135+
Polly.RateLimiting.dll
128136
Pomelo.EntityFrameworkCore.MySql.dll
129137
RedLockNet.Abstractions.dll
130138
RedLockNet.SERedis.dll
@@ -139,7 +147,6 @@ Serilog.Settings.Configuration.dll
139147
Serilog.Sinks.Console.dll
140148
Serilog.Sinks.Debug.dll
141149
Serilog.Sinks.File.dll
142-
sni.dll
143150
StackExchange.Redis.dll
144151
Swashbuckle.AspNetCore.Annotations.dll
145152
Swashbuckle.AspNetCore.Filters.Abstractions.dll
@@ -156,13 +163,11 @@ System.Composition.Hosting.dll
156163
System.Composition.Runtime.dll
157164
System.Composition.TypedParts.dll
158165
System.Configuration.ConfigurationManager.dll
159-
System.Data.SqlClient.dll
160166
System.Drawing.Common.dll
161167
System.IdentityModel.Tokens.Jwt.dll
162168
System.IO.Abstractions.dll
163169
System.Linq.Async.dll
164170
System.Memory.Data.dll
165-
System.Net.WebSockets.WebSocketProtocol.dll
166171
System.Runtime.Caching.dll
167172
System.Security.Cryptography.ProtectedData.dll
168173
System.Security.Cryptography.Xml.dll

src/VirtoCommerce.Platform.Security/Extensions/ClaimsPrincipalExtensions.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ public static bool IsExternalSignIn(this ClaimsPrincipal claimsPrincipal)
1414

1515
public static string GetAuthenticationMethod(this ClaimsPrincipal claimsPrincipal)
1616
{
17-
return claimsPrincipal?.GetClaim(ClaimTypes.AuthenticationMethod);
17+
return claimsPrincipal?.FindFirstValue(ClaimTypes.AuthenticationMethod);
1818
}
1919

2020
public static ClaimsPrincipal SetAuthenticationMethod(this ClaimsPrincipal claimsPrincipal, string value, IList<string> destinations)

src/VirtoCommerce.Platform.Security/VirtoCommerce.Platform.Security.csproj

+1
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
<PackageReference Include="Microsoft.AspNetCore.Identity.EntityFrameworkCore" Version="8.0.8" />
2323
<PackageReference Include="Microsoft.AspNetCore.Mvc.NewtonsoftJson" Version="8.0.8" />
2424
<PackageReference Include="Microsoft.Extensions.Identity.Core" Version="8.0.8" />
25+
<PackageReference Include="Microsoft.IdentityModel.Validators" Version="8.1.2" />
2526
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0" PrivateAssets="All" />
2627
<PackageReference Include="OpenIddict.EntityFrameworkCore" Version="5.8.0" />
2728
</ItemGroup>

src/VirtoCommerce.Platform.Web/wwwroot/js/app/security/services/auth.js

+3-5
Original file line numberDiff line numberDiff line change
@@ -103,12 +103,10 @@ angular.module('platformWebApp')
103103
};
104104

105105
authContext.logout = function () {
106-
var extenralSignInData = externalSignInStorage.get();
107-
if (extenralSignInData && extenralSignInData.providerType) {
106+
var externalSignInData = externalSignInStorage.get();
107+
if (externalSignInData && externalSignInData.providerType) {
108108
externalSignInStorage.remove();
109-
changeAuth({});
110-
var url = 'externalsignin/signout?authenticationType=' + extenralSignInData.providerType;
111-
$window.location.href = url;
109+
$window.location.href = 'externalsignin/signout?authenticationType=' + externalSignInData.providerType;
112110
}
113111
else {
114112
authDataStorage.clearStoredData();

0 commit comments

Comments
 (0)