Skip to content

Commit d94809f

Browse files
committed
fix: test
1 parent 1ae279f commit d94809f

File tree

3 files changed

+34
-26
lines changed

3 files changed

+34
-26
lines changed

src/VirtoCommerce.Platform.Security/Services/BaseUserSignInValidator.cs

+21-23
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
1-
using System;
21
using System.Collections.Generic;
32
using System.Threading.Tasks;
4-
using Microsoft.AspNetCore.Identity;
53
using VirtoCommerce.Platform.Core.Security;
64
using VirtoCommerce.Platform.Security.Model;
75

@@ -11,30 +9,30 @@ public class BaseUserSignInValidator : IUserSignInValidator
119
{
1210
public int Priority { get; set; }
1311

14-
public Task<IList<TokenLoginResponse>> ValidateUserAsync(ApplicationUser user, SignInResult signInResult, IDictionary<string, object> context)
12+
public Task<IList<TokenLoginResponse>> ValidateUserAsync(ApplicationUser user, IDictionary<string, object> context)
1513
{
1614
var result = new List<TokenLoginResponse>();
1715

18-
if (!signInResult.Succeeded)
19-
{
20-
var detailedErrors = GetDetailedErrors(context);
21-
if (!detailedErrors)
22-
{
23-
result.Add(SecurityErrorDescriber.LoginFailed());
24-
}
25-
else if (signInResult.IsLockedOut)
26-
{
27-
var permanentLockOut = user.LockoutEnd == DateTime.MaxValue.ToUniversalTime();
28-
result.Add(permanentLockOut ? SecurityErrorDescriber.UserIsLockedOut() : SecurityErrorDescriber.UserIsTemporaryLockedOut());
29-
}
30-
}
31-
else
32-
{
33-
if (user.PasswordExpired)
34-
{
35-
result.Add(SecurityErrorDescriber.PasswordExpired());
36-
}
37-
}
16+
//if (!signInResult.Succeeded)
17+
//{
18+
// var detailedErrors = GetDetailedErrors(context);
19+
// if (!detailedErrors)
20+
// {
21+
// result.Add(SecurityErrorDescriber.LoginFailed());
22+
// }
23+
// else if (signInResult.IsLockedOut)
24+
// {
25+
// var permanentLockOut = user.LockoutEnd == DateTime.MaxValue.ToUniversalTime();
26+
// result.Add(permanentLockOut ? SecurityErrorDescriber.UserIsLockedOut() : SecurityErrorDescriber.UserIsTemporaryLockedOut());
27+
// }
28+
//}
29+
//else
30+
//{
31+
// if (user.PasswordExpired)
32+
// {
33+
// result.Add(SecurityErrorDescriber.PasswordExpired());
34+
// }
35+
//}
3836

3937
return Task.FromResult<IList<TokenLoginResponse>>(result);
4038
}
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
using System.Collections.Generic;
22
using System.Threading.Tasks;
3-
using Microsoft.AspNetCore.Identity;
43
using VirtoCommerce.Platform.Core.Security;
54
using VirtoCommerce.Platform.Security.Model;
65

@@ -10,6 +9,6 @@ public interface IUserSignInValidator
109
{
1110
public int Priority { get; set; }
1211

13-
Task<IList<TokenLoginResponse>> ValidateUserAsync(ApplicationUser user, SignInResult signInResult, IDictionary<string, object> context);
12+
Task<IList<TokenLoginResponse>> ValidateUserAsync(ApplicationUser user, IDictionary<string, object> context);
1413
}
1514
}

src/VirtoCommerce.Platform.Web/Controllers/Api/AuthorizationController.cs

+12-1
Original file line numberDiff line numberDiff line change
@@ -100,14 +100,25 @@ public async Task<ActionResult> Exchange()
100100
// Validate the username/password parameters and ensure the account is not locked out.
101101
var result = await _signInManager.CheckPasswordSignInAsync(user, openIdConnectRequest.Password, lockoutOnFailure: true);
102102

103+
if (!result.Succeeded)
104+
{
105+
return BadRequest(SecurityErrorDescriber.LoginFailed());
106+
}
107+
103108
var context = new Dictionary<string, object>(StringComparer.OrdinalIgnoreCase)
104109
{
105110
{ "detailedErrors", _passwordLoginOptions.DetailedErrors },
106111
};
107112

113+
var storeId = openIdConnectRequest.GetParameter("storeId");
114+
if (storeId != null)
115+
{
116+
context.Add("storeId", storeId.Value);
117+
}
118+
108119
foreach (var loginValidation in _userSignInValidators.OrderByDescending(x => x.Priority).ThenBy(x => x.GetType().Name).ToList())
109120
{
110-
var validationErrors = await loginValidation.ValidateUserAsync(user, result, context);
121+
var validationErrors = await loginValidation.ValidateUserAsync(user, context);
111122
var error = validationErrors.FirstOrDefault();
112123
if (error != null)
113124
{

0 commit comments

Comments
 (0)