refactor(download): extract constants to JSON and reorganize download utils

Moved downloadConstants.json and downloadUtils.tsx into a dedicated subdirectory.
Removed redundant UserOs array and now infer it dynamically from OperatingSystemLabel keys.

Fixes: nodejs#7561
Signed-off-by: vishal <vishalkumarvkvk988@gmail.com>

Author: Vishal-K-988

.pre-commit-config.yaml

@@ -1,18 +1,18 @@
 repos:
-- repo: https://github.com/gitleaks/gitleaks
-  rev: v8.16.3
-  hooks:
-  - id: gitleaks
-- repo: https://github.com/jumanjihouse/pre-commit-hooks
-  rev: 3.0.0
-  hooks:
-  - id: shellcheck
-- repo: https://github.com/pre-commit/mirrors-eslint
-  rev: v8.38.0
-  hooks:
-  - id: eslint
-- repo: https://github.com/pre-commit/pre-commit-hooks
-  rev: v4.4.0
-  hooks:
-  - id: end-of-file-fixer
-  - id: trailing-whitespace
+  - repo: https://github.com/gitleaks/gitleaks
+    rev: v8.16.3
+    hooks:
+      - id: gitleaks
+  - repo: https://github.com/jumanjihouse/pre-commit-hooks
+    rev: 3.0.0
+    hooks:
+      - id: shellcheck
+  - repo: https://github.com/pre-commit/mirrors-eslint
+    rev: v8.38.0
+    hooks:
+      - id: eslint
+  - repo: https://github.com/pre-commit/pre-commit-hooks
+    rev: v4.4.0
+    hooks:
+      - id: end-of-file-fixer
+      - id: trailing-whitespace

apps/site/components/Downloads/Release/InstallationMethodDropdown.tsx

@@ -7,11 +7,12 @@ import type { FC } from 'react';
 
 import { ReleaseContext } from '#site/providers/releaseProvider';
 import type { InstallationMethod } from '#site/types/release';
+
 import {
   nextItem,
   INSTALL_METHODS,
   parseCompat,
-} from '#site/util/downloadUtils';
+} from '../../../downloadUtils/index';
 
 const InstallationMethodDropdown: FC = () => {
   const release = useContext(ReleaseContext);

apps/site/components/Downloads/Release/OperatingSystemDropdown.tsx

@@ -8,11 +8,12 @@ import type { FC } from 'react';
 import { useClientContext } from '#site/hooks';
 import { ReleaseContext } from '#site/providers/releaseProvider';
 import type { UserOS } from '#site/types/userOS';
+
 import {
   nextItem,
   OPERATING_SYSTEMS,
   parseCompat,
-} from '#site/util/downloadUtils';
+} from '../../../downloadUtils/index';
 
 type OperatingSystemDropdownProps = { exclude?: Array<UserOS> };
 

apps/site/components/Downloads/Release/PackageManagerDropdown.tsx

@@ -7,11 +7,12 @@ import type { FC } from 'react';
 
 import { ReleaseContext } from '#site/providers/releaseProvider';
 import type { PackageManager } from '#site/types/release';
+
 import {
   nextItem,
   PACKAGE_MANAGERS,
   parseCompat,
-} from '#site/util/downloadUtils';
+} from '../../../downloadUtils/index';
 
 const PackageManagerDropdown: FC = () => {
   const release = useContext(ReleaseContext);

apps/site/components/Downloads/Release/PlatformDropdown.tsx

@@ -8,9 +8,10 @@ import { useEffect, useContext, useMemo } from 'react';
 import { useClientContext } from '#site/hooks';
 import { ReleaseContext } from '#site/providers/releaseProvider';
 import type { UserPlatform } from '#site/types/userOS';
-import { PLATFORMS, nextItem, parseCompat } from '#site/util/downloadUtils';
 import { getUserPlatform } from '#site/util/getUserPlatform';
 
+import { PLATFORMS, nextItem, parseCompat } from '../../../downloadUtils/index';
+
 const PlatformDropdown: FC = () => {
   const { architecture, bitness } = useClientContext();
 

apps/site/components/Downloads/Release/PrebuiltDownloadButtons.tsx

@@ -8,12 +8,12 @@ import type { FC } from 'react';
 
 import Button from '#site/components/Common/Button';
 import { ReleaseContext } from '#site/providers/releaseProvider';
-import {
-  OperatingSystemLabel,
-  OS_NOT_SUPPORTING_INSTALLERS,
-} from '#site/util/downloadUtils';
 import { getNodeDownloadUrl } from '#site/util/getNodeDownloadUrl';
 
+import {
+  OS_NOT_SUPPORTING_INSTALLERS,
+  OperatingSystemLabel,
+} from '../../../downloadUtils/index';
 // Retrieves the pure extension piece from the input string
 const getExtension = (input: string) => String(input.split('.').slice(-1));
 

apps/site/components/Downloads/Release/ReleaseCodeBox.tsx

@@ -15,9 +15,10 @@ import {
   ReleasesContext,
 } from '#site/providers/releaseProvider';
 import type { ReleaseContextType } from '#site/types/release';
-import { INSTALL_METHODS } from '#site/util/downloadUtils';
 import { highlightToHtml } from '#site/util/getHighlighter';
 
+import { INSTALL_METHODS } from '../../../downloadUtils/index';
+
 // Creates a minimal JavaScript interpreter for parsing the JavaScript code from the snippets
 // Note: that the code runs inside a sandboxed environment and cannot interact with any code outside of the sandbox
 // It also does not have access to any Global or Window objects, nor it can execute code on the end-user's browser

apps/site/downloadUtils/constants.json

@@ -0,0 +1,38 @@
+{
+  "OperatingSystemLabel": {
+    "WIN": "Windows",
+    "MAC": "macOS",
+    "LINUX": "Linux",
+    "AIX": "AIX",
+    "OTHER": "Other",
+    "LOADING": "N/A"
+  },
+
+  "InstallationMethodLabel": {
+    "NVM": "nvm",
+    "FNM": "fnm",
+    "BREW": "Brew",
+    "CHOCO": "Chocolatey",
+    "DEVBOX": "Devbox",
+    "DOCKER": "Docker",
+    "N": "n",
+    "VOLTA": "Volta"
+  },
+  "PackageManagerLabel": {
+    "NPM": "npm",
+    "YARN": "Yarn",
+    "PNPM": "pnpm"
+  },
+  "UserPlatform": [
+    "arm64",
+    "armv7l",
+    "ppc64le",
+    "ppc64",
+    "s390x",
+    "ppc64",
+    "x64",
+    "x86"
+  ],
+  "UserBitness": ["64", "32"],
+  "UserArchitecture": ["arm", "x86"]
+}

apps/site/util/downloadUtils.tsx renamed to apps/site/downloadUtils/index.tsx

@@ -6,9 +6,19 @@ import satisfies from 'semver/functions/satisfies';
 
 import type { NodeReleaseStatus } from '#site/types';
 import type * as Types from '#site/types/release';
-import type { UserOS, UserPlatform } from '#site/types/userOS';
+import type { UserPlatform } from '#site/types/userOS';
+import type { UserOS } from '#site/types/userOS';
 
-// This is a manual list of OS's that do not support/have a way of being installed
+import downloadConstants from '../../site/downloadUtils/constants.json';
+
+const { InstallationMethodLabel } = downloadConstants;
+export const { OperatingSystemLabel } = downloadConstants;
+// const InstallationMethodLabel = downloadConstants.InstallationMethod;
+// export const OperatingSystemLabel = downloadConstants.OperatingSystem;
+const { PackageManagerLabel } = downloadConstants;
+
+// This is a manual list of OS's that do not sup
+// port/have a way of being installed
 // with an executable installer. This is used to disable the installer button.
 // Note: Windows has one tiny exception for x64 on Node.js versions < 4.0.0
 export const OS_NOT_SUPPORTING_INSTALLERS: Array<UserOS | 'LOADING'> = [
@@ -18,32 +28,6 @@ export const OS_NOT_SUPPORTING_INSTALLERS: Array<UserOS | 'LOADING'> = [
   'LOADING',
 ];
 
-export enum OperatingSystemLabel {
-  WIN = 'Windows',
-  MAC = 'macOS',
-  LINUX = 'Linux',
-  AIX = 'AIX',
-  OTHER = 'Other',
-  LOADING = 'N/A',
-}
-
-export enum InstallationMethodLabel {
-  NVM = 'nvm',
-  FNM = 'fnm',
-  BREW = 'Brew',
-  CHOCO = 'Chocolatey',
-  DEVBOX = 'Devbox',
-  DOCKER = 'Docker',
-  N = 'n',
-  VOLTA = 'Volta',
-}
-
-export enum PackageManagerLabel {
-  NPM = 'npm',
-  YARN = 'Yarn',
-  PNPM = 'pnpm',
-}
-
 type DownloadCompatibility = {
   os: Array<UserOS | 'LOADING'>;
   installMethod: Array<Types.InstallationMethod | ''>;
@@ -125,6 +109,7 @@ export const parseCompat = <
   }));
 };
 
+// Here the list of Operating System Dropdown items are defined !
 export const OPERATING_SYSTEMS: Array<DownloadDropdownItem<UserOS>> = [
   {
     label: OperatingSystemLabel.WIN,
@@ -152,6 +137,8 @@ export const OPERATING_SYSTEMS: Array<DownloadDropdownItem<UserOS>> = [
   },
 ];
 
+// Here the list of Install Method Dropdown items are defined !
+
 export const INSTALL_METHODS: Array<
   DownloadDropdownItem<Types.InstallationMethod> &
     // Since the ReleaseCodeBox requires an info key to be provided, we force this
@@ -229,6 +216,8 @@ export const INSTALL_METHODS: Array<
   },
 ];
 
+// Here the list of Package Manager  Dropdown items are defined !
+
 export const PACKAGE_MANAGERS: Array<
   DownloadDropdownItem<Types.PackageManager>
 > = [
@@ -252,8 +241,10 @@ export const PACKAGE_MANAGERS: Array<
   },
 ];
 
+// Here the list Platform and their specific specification items are defined !
+
 export const PLATFORMS: Record<
-  UserOS,
+  UserOS | 'LOADING',
   Array<DownloadDropdownItem<UserPlatform>>
 > = {
   WIN: [
@@ -320,4 +311,5 @@ export const PLATFORMS: Record<
     },
   ],
   OTHER: [],
+  LOADING: [],
 };

apps/site/types/userOS.ts

@@ -1,15 +1,15 @@
-export type UserOS = 'MAC' | 'WIN' | 'LINUX' | 'AIX' | 'OTHER';
+import type { OperatingSystemLabel } from '../downloadUtils/constants.json';
+import type downloadConstants from '../downloadUtils/constants.json';
 
-export type UserBitness = '64' | '32';
+// This infers the keys from OperatingSystemLabel as the UserOS type.
+export type UserOS = keyof typeof OperatingSystemLabel;
 
-export type UserArchitecture = 'arm' | 'x86';
+// Derive the union type of UserPlatform from the JSON array values.
+export type UserPlatform = (typeof downloadConstants.UserPlatform)[number];
 
-export type UserPlatform =
-  | 'arm64'
-  | 'armv7l'
-  | 'ppc64le'
-  | 'ppc64'
-  | 's390x'
-  | 'ppc64'
-  | 'x64'
-  | 'x86';
+// Derive the union type of UserBitness from the JSON array values.
+export type UserBitness = (typeof downloadConstants.UserBitness)[number];
+
+// Derive the union type of UserArchitecture from the JSON array values.
+export type UserArchitecture =
+  (typeof downloadConstants.UserArchitecture)[number];