refactor(proteome-discoverer): Add validation for input columns #87
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
We encountered this issue where the PD to MSstatsTMT converter is having problems with returning a useful validation message. In
.mergeAnnotation
, it spits out an error message saying to inspect the annotation file, but in reality, it's the input PD file that is missing columns.Changes
.validatePDTMTInputColumns
to the PD to MSstatsTMT clean function (raw file cleaning occurs before annotation file merging)channels
column validation to be in the helper function.Testing
Checklist Before Requesting a Review