fix(memory): Reduce memory and cpu usage for standardizeColNames #95
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Using the dataset from the Fragpipe-MSstats Nature Protocols paper, I discovered that there are sections of the MSstatsConvert code that are not efficient in space and time.
In one case, when running
.standardizeColnames
here, I saw that the memory available decreased by 70GB (despite our dataset being 20GB). This code also took 6.5 minutes to run.Changes
Testing
Checklist Before Requesting a Review