-
Notifications
You must be signed in to change notification settings - Fork 6
[Feature request] FileTextSearcher - return text #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hello! Regarding your suggestion, Probably, in some specific cases, apparently like yours, found files may be large and it makes sense to add option I could try to add the appropriate property to FileEventArgs class. What do you think about it? |
Yep that sounds good. I admit that this tool runs so fast that this wouldn't be any major performance improvement, and I suppose it could have a down side of more memory usage. At the moment I'm just using the FileSearcher and then reading the files in the FilesFound event, but my code isn't quite as multi-thread-optimized as yours is. |
I added possibility to get file content with the file path, but since these changes cover only this particular case |
Uh oh!
There was an error while loading. Please reload this page.
Thanks for open sourcing this!
Currently would need to re-read the whole file if we need to check the text of the matching file, which is inefficient I think, would be good to have an option to return the text in the result.
The text was updated successfully, but these errors were encountered: