Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"WebDriver didn't wasn't quit properly" on main, but 0.35 works #268

Open
BlinkyStitt opened this issue Feb 2, 2025 · 2 comments
Open

Comments

@BlinkyStitt
Copy link

BlinkyStitt commented Feb 2, 2025

I have some code working with thirtyfour v0.35.

I wanted to make some modifications to the repo and so I forked main, but then my app started behaving strangely. It doesn't ever exit. When I press [ctrl+c], I detect that and call web_driver.quit().await.ok(), but on main that throws this error now:

thread 'tokio-runtime-worker' panicked at /Users/bryan/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.43.0/src/runtime/time/entry.rs:568:9:
A Tokio 1.x context was found, but it is being shutdown.
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

I think the changes to change how drop worked have created other bugs.

I think this is the commit that breaks things: 6c67941

I reverted that in a local checkout and now the app at least exits instead of hangs. but it still does say "WebDriver didn't wasn't quit properly"

Calling quit does give an error. That is probably related:

Error: The WebDriver request returned an error: error sending request for url (http://localhost:9515/session/5062df7f7afbe1e4ee482b249635c133)
@Vrtgs
Copy link
Owner

Vrtgs commented Feb 3, 2025

will look into this, the new drop logic is a bit messy

@BlinkyStitt
Copy link
Author

BlinkyStitt commented Feb 5, 2025

I think the problem might be related to having a chrome devtools object. That clones the session handle, so maybe the drop isn't running when expected?

I'll try manually dropping before calling quit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants