Skip to content

Code review #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 10 commits into
base: review
Choose a base branch
from
Draft

Code review #1

wants to merge 10 commits into from

Conversation

multimeric
Copy link
Member

No description provided.

Copy link
Member Author

@multimeric multimeric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General comments:

  • In the long run, consider dockerizing the steps for full reproducibility/portability

I'll review the Python code later.

edoyango and others added 3 commits May 3, 2023 09:05
Co-authored-by: Michael Milton <ttmigueltt@gmail.com>
Co-authored-by: Michael Milton <ttmigueltt@gmail.com>
Co-authored-by: Michael Milton <ttmigueltt@gmail.com>
Copy link
Member Author

@multimeric multimeric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't gone into much detail with the Python because you didn't write all of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants