fix: correct complexity metric

Watt3r · Watt3r · commit 9306f36d7be9 · 2024-01-29T12:10:14.000Z
diff --git a/internal/handlers/common.go b/internal/handlers/common.go
@@ -23,8 +23,6 @@ func (c *Controller) StatsdMiddleware(f http.HandlerFunc) http.HandlerFunc {
 			path = "svg"
 		}
 
-		complexity := len(req.URL.Query())
-		c.Metrics.Histogram("d2-live."+path+".complexity", float64(complexity), []string{}, 1)
 		c.Metrics.Histogram("d2-live."+path, time.Now().Sub(start).Seconds(), []string{}, 1)
 	}
 }
diff --git a/internal/handlers/get_svg.go b/internal/handlers/get_svg.go
@@ -30,6 +30,9 @@ func (c *Controller) GetD2SVGHandler(rw http.ResponseWriter, req *http.Request)
 		return
 	}
 
+	// Emit complexity metric
+	c.Metrics.Histogram("d2-live.complexity", float64(len(urlencoded)), []string{}, 1)
+
 	svg, err := c.handleGetD2SVG(ctx, urlencoded)
 
 	if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -23,8 +23,6 @@ func (c *Controller) StatsdMiddleware(f http.HandlerFunc) http.HandlerFunc {`
`23`	`23`	`path = "svg"`
`24`	`24`	`}`
`25`	`25`
`26`		`- complexity := len(req.URL.Query())`
`27`		`- c.Metrics.Histogram("d2-live."+path+".complexity", float64(complexity), []string{}, 1)`
`28`	`26`	`c.Metrics.Histogram("d2-live."+path, time.Now().Sub(start).Seconds(), []string{}, 1)`
`29`	`27`	`}`
`30`	`28`	`}`
Original file line number	Diff line number	Diff line change
`@@ -30,6 +30,9 @@ func (c Controller) GetD2SVGHandler(rw http.ResponseWriter, req http.Request)`
`30`	`30`	`return`
`31`	`31`	`}`
`32`	`32`
	`33`	`+ // Emit complexity metric`
	`34`	`+ c.Metrics.Histogram("d2-live.complexity", float64(len(urlencoded)), []string{}, 1)`
	`35`	`+`
`33`	`36`	`svg, err := c.handleGetD2SVG(ctx, urlencoded)`
`34`	`37`
`35`	`38`	`if err != nil {`