Skip to content

Commit fb28f04

Browse files
author
tangjiawei
committed
#830 custom template bug
1 parent aa0eedc commit fb28f04

File tree

1 file changed

+6
-22
lines changed

1 file changed

+6
-22
lines changed

monitor-server/services/db/log_metric.go

+6-22
Original file line numberDiff line numberDiff line change
@@ -1575,13 +1575,12 @@ func getDeleteMetricActions(metricGuid string) (actions []*Action, affectEndpoin
15751575
func ListLogMetricGroups(logMetricMonitor, metricKey string) (result []*models.LogMetricGroupObj) {
15761576
result = []*models.LogMetricGroupObj{}
15771577
var logMetricGroupTable []*models.LogMetricGroup
1578-
var err error
15791578
x.SQL("select * from log_metric_group where log_metric_monitor=? order by update_time desc", logMetricMonitor).Find(&logMetricGroupTable)
15801579
for _, v := range logMetricGroupTable {
15811580
v.CreateTimeString = v.CreateTime.Format(models.DatetimeFormat)
15821581
v.UpdateTimeString = v.UpdateTime.Format(models.DatetimeFormat)
15831582
logMetricGroupData := &models.LogMetricGroupObj{LogMetricGroup: *v}
1584-
if v.LogMonitorTemplate != "" {
1583+
if v.LogMonitorTemplate != "" && v.LogType != "custom" {
15851584
tmpTemplateObj, tmpGetTemplateErr := GetLogMonitorTemplate(v.LogMonitorTemplate)
15861585
if tmpGetTemplateErr != nil {
15871586
log.Logger.Error("ListLogMetricGroups fail get template data ", log.String("templateGuid", v.LogMonitorTemplate), log.Error(tmpGetTemplateErr))
@@ -1592,26 +1591,11 @@ func ListLogMetricGroups(logMetricMonitor, metricKey string) (result []*models.L
15921591
log.Logger.Error("ListLogMetricGroups getLogMetricGroupMapData fail ", log.String("logMetricGroupGuid", v.Guid), log.Error(getStringMapErr))
15931592
}
15941593
logMetricGroupData.LogMonitorTemplateName = tmpTemplateObj.Name
1595-
// 业务配置引用自定义模版,可能会修改 ParamList参数,需要特殊处理,不走通用模版读取逻辑
1596-
if v.LogType == "custom" {
1597-
var logMetricParamRows []*models.LogMetricParam
1598-
if err = x.SQL("select * from log_metric_param where log_metric_group=?", v.Guid).Find(&logMetricParamRows); err != nil {
1599-
log.Logger.Error("Query table log_metric_param fail", log.Error(err))
1600-
}
1601-
for _, row := range logMetricParamRows {
1602-
tmpParamObj := models.LogMetricParamObj{LogMetricParam: *row, StringMap: []*models.LogMetricStringMapTable{}}
1603-
if stringMapData, ok := logMetricStringMapData[row.Name]; ok {
1604-
tmpParamObj.StringMap = stringMapData
1605-
}
1606-
logMetricGroupData.ParamList = append(logMetricGroupData.ParamList, &tmpParamObj)
1607-
}
1608-
} else {
1609-
// 读取 模版的 ParamList
1610-
for _, tplParam := range tmpTemplateObj.ParamList {
1611-
tmpLogMetricParamObj := tplParam.TransToLogParam()
1612-
tmpLogMetricParamObj.StringMap = logMetricStringMapData[tmpLogMetricParamObj.Name]
1613-
logMetricGroupData.ParamList = append(logMetricGroupData.ParamList, tmpLogMetricParamObj)
1614-
}
1594+
// 读取 模版的 ParamList
1595+
for _, tplParam := range tmpTemplateObj.ParamList {
1596+
tmpLogMetricParamObj := tplParam.TransToLogParam()
1597+
tmpLogMetricParamObj.StringMap = logMetricStringMapData[tmpLogMetricParamObj.Name]
1598+
logMetricGroupData.ParamList = append(logMetricGroupData.ParamList, tmpLogMetricParamObj)
16151599
}
16161600
for _, tplMetric := range tmpTemplateObj.MetricList {
16171601
output := tplMetric.TransToLogMetric()

0 commit comments

Comments
 (0)