Add wabt::Const::set_funcref(uintptr_t) overload #2610
Conversation
include/wabt/ir.h
Outdated
| @@ -154,6 +154,7 @@ struct Const { | |||
| set_expected_nan(0, nan); | |||
| } | |||
| void set_funcref() { From<uintptr_t>(Type::FuncRef, 0); } | |||
| void set_funcref(uintptr_t x) { From<uintptr_t>(Type::FuncRef, x); } | |||
There was a problem hiding this comment.
Is the <uintptr_t> needed here? I see the its not present on the line below.
There was a problem hiding this comment.
Oh yea, not required, removed.
This allows wabt::Const funcrefs to be created from bits read from other sources, e.g. a WASM engine under test.
|
LGTM, although I'm a little hesitant to make changes like this without a test case. Can you explain a little bit more about why you need it? What exactly are you trying to do? What is a "wasm engine under test" in this context? |
|
We discussed this change offline, and I think we can close this pull request. We're using wabt internal APIs to parse WAST files and implement the commands in those WAST files. For example, we implement |
This allows wabt::Const funcrefs to be created from bits read from other sources, e.g. a WASM engine under test.