-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GStreamer][MediaCapabilities] missing validation of HdrMetadataType and TransferFunction during decodingInfo method #1453
Comments
@emutavchi : is it, what for you need additional API to set HDR types and EOTF? |
Based on the release notes from the gstreamer: https://gstreamer.freedesktop.org/releases/1.18/
we can assume that HDR types and EOTF things are supported by gstreamer >= 1.18. |
@pgorszkowski-igalia we need a way to configure browser to accept HDR mime types MediaSource.isTypeSupported, for example to pass tests like: |
Thanks @emutavchi . The failing test: "10. isTypeSupported EOTF Support" validates MIME types which also contain information about EOTF: "eotf=smpte2084" and "eotf=arib-std-b67" are expected to be valid, while "eotf=strobevision" is expected to be invalid and the test expects that for invalid EOTF in MIME type, "isTypeSupported" should fail. MIME type specification does not specify what EOTF values are valid and also in https://w3c.github.io/media-source/#istypesupported-method there is nothing about "optional parameters" and EOTF valid values. I will try to find some more information about that but it seems that these tests are specific for some custom implementation (at least it is my assumption). |
EOTF parameter parser is implemented in Cobalt: It bases on "YouTube TV HTML5 Technical Requirements" defined in https://developers.google.com/youtube/devices/living-room/files/pdf-guides/YouTube_TV_HTML5_Technical_Requirements_2018.pdf |
I have added in upstream (WebKit/WebKit#40539) the similar implementation as is in Cobalt. With this implementation the tests from https://ytlr-cert.appspot.com/latest/main.html?&test_type=formatsupport-test&tests=10,11,12#1739287094977 pass. |
And downstream PR: #1463 |
@emutavchi : #1463 is merged so now the tests from https://ytlr-cert.appspot.com/latest/main.html?&test_type=formatsupport-test&tests=10,11,12#1739287094977 pass. |
decodingInfo method: https://www.w3.org/TR/media-capabilities/#decodinginfo-method, in case of VideoConfiguration (https://www.w3.org/TR/media-capabilities/#videoconfiguration), should also validate HDRMetadataType (https://www.w3.org/TR/media-capabilities/#enumdef-hdrmetadatatype) and TransferFunction (https://www.w3.org/TR/media-capabilities/#transferfunction).
Available video decoders can provide HDRMetadataType and TransferFunction which they support.
The text was updated successfully, but these errors were encountered: