-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to Psr containers #154
Conversation
Thanks @imonteiro 👏. So: changelog wise: this PR deprecated both PHP 7.2 and 7.3, correct? Was that a requriement to update to service manager 3.11? |
Yes, laminas-servicemanager 3.11 require PHP 7.4. Since laminas-servicemanager 3.3, it requires both Interop and Psr containers, but I didn't tested if it work. I bump to 3.11 as this release replace container-interop by Psr container. If you prefer keep the laminas-servicemanager at 3.3, I can try it. |
No I'm fine with moving a bit ahead. PHP 7.3 is EOL anywayz. I think it is important to keep supporting 7.4 though, so there is at least one 7.x version supported. |
I've released a beta, can you try it out, and let me know if it works for you? |
I just tested a simple example with mezzio and postmark and everything went fine. Thanks @roelvanduijnhoven |
Thanks! New release launched. |
Move to Psr containers (deprecating Interop\Container\ContainerInterface) and bump the minimum version of
laminas-servicemanager
to 3.11, which deprecate Interop\Container\ContainerInterface.Small fix in composer.json (zf -> laminas).