Fix speed calculation in SwitchingAnemometer #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the DigitalPortResult.Delta property to determin duration of change from one edge to the next. Ignore impossibly high speeds (> 500 km/hr)
ctacke
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Driver
Use the Delta property of the observed DigitalPortResult to determine interval from one edge to the next.
Ignore impossibly high speeds set by new property MaxSpeed, defaults to 500 km/hr.
Minor code refactor to make code execution clearer that speed returned is zero if to much time between samples, to few samples, or speed is too high.
Add clarification to some comments
Sample
Added commented code for testing the SwitchingAnemometer by driving the input from a PWM port running at set frequency.