Skip to content

Commit 7fc689b

Browse files
committed
lstsq test coverage
1 parent 3992c77 commit 7fc689b

File tree

3 files changed

+23
-1
lines changed

3 files changed

+23
-1
lines changed

tests/lstsq/test_base.py

+2
Original file line numberDiff line numberDiff line change
@@ -314,6 +314,8 @@ def test_fit(self):
314314
out = solver.fit(D, Z)
315315
assert out is solver
316316

317+
repr(solver)
318+
317319
def test_predict(self, k=20, d=11, r=3):
318320
"""Test predict()."""
319321
# Set up and manually solve a least-squares problem.

tests/lstsq/test_tikhonov.py

+16-1
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,9 @@ def test_fit(self, k=20, d=11, r=3):
8787
solver = self.Solver(1)
8888
A = np.random.standard_normal((k, d))
8989
B = np.random.standard_normal((r, k))
90+
solver.verify()
9091
solver.fit(A, B)
92+
solver.verify()
9193

9294
for attr, shape in [
9395
("_ZPhi", (r, d)),
@@ -101,6 +103,8 @@ def test_fit(self, k=20, d=11, r=3):
101103
assert isinstance(obj, np.ndarray)
102104
assert obj.shape == shape
103105

106+
repr(solver)
107+
104108
def test_predict(self, k=20, d=10, r=5):
105109
"""Test predict()."""
106110
solver1D = self.Solver(0)
@@ -346,6 +350,8 @@ def test_regularizer(self, k=10, d=6, r=3):
346350
solver.fit(A, B)
347351
assert solver.r == r
348352

353+
repr(solver)
354+
349355
# Main methods ------------------------------------------------------------
350356
def test_predict(self, k=20, d=10):
351357
"""Test predict()."""
@@ -551,13 +557,20 @@ def test_regularizer(self, k=20, d=11, r=3):
551557
assert solver.regularizer.shape == (d, d)
552558
assert np.all(solver.regularizer == 2 * np.eye(d))
553559

560+
repr(solver)
561+
solver.method = "normal"
562+
repr(solver)
563+
554564
# Main methods ------------------------------------------------------------
555565
def test_fit(self, k=20, d=10, r=5):
556566
"""Test fit()."""
557567
Z = np.zeros((d, d))
558568
A = np.random.standard_normal((k, d))
559569
B = np.random.standard_normal((r, k))
560-
solver = self.Solver(Z).fit(A, B)
570+
solver = self.Solver(Z)
571+
solver.verify(d=d, r=r)
572+
solver.fit(A, B)
573+
solver.verify()
561574

562575
for attr, shape in [
563576
("data_matrix", (k, d)),
@@ -826,6 +839,8 @@ def test_regularizer(self, k=10, d=6, r=3):
826839
solver.regularizer = [[i] * d for i in range(1, r + 1)]
827840
assert np.all(solver.regularizer[0] == np.eye(d))
828841

842+
repr(solver)
843+
829844
# Main methods ------------------------------------------------------------
830845
def test_predict(self, k=20, d=10):
831846
"""Test lstsq._tikhonov.TikhonovDecoupledSolver.predict()."""

tests/lstsq/test_total.py

+5
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,13 @@ def test_fit(self, k=20, d=10, r=6):
1818
D = np.random.standard_normal((k, d))
1919
Z = np.random.random((r, k))
2020
solver = self.Solver()
21+
solver.verify()
2122
out = solver.fit(D, Z)
2223
assert out is solver
24+
repr(solver)
25+
assert isinstance(solver.augcond, float)
26+
assert isinstance(solver.error, float)
27+
solver.verify()
2328

2429
def test_predict(self, k=15, d=7, r=5):
2530
"""Test predict()."""

0 commit comments

Comments
 (0)