Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for complex values states/operators/snapshot-matrices #51

Open
opaliss opened this issue Dec 18, 2023 · 1 comment
Open

Allow for complex values states/operators/snapshot-matrices #51

opaliss opened this issue Dec 18, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@opaliss
Copy link

opaliss commented Dec 18, 2023

Is your feature request related to a problem? Please describe.
It would be great to allow for complex-valued states/operators/snapshot matrices.

Describe the solution you'd like
Allow integration of complex-valued ODEs + solve the least squares problem using complex-valued snapshot matrices. I believe this could be done easily by changing the dtype in certain definitions to allow complex128.

@opaliss opaliss added the enhancement New feature or request label Dec 18, 2023
@shanemcq18
Copy link
Member

shanemcq18 commented Dec 18, 2023

This is a great idea. Ideally we should check the type of the states/inputs so we don't use a complex type unless necessary, but this shouldn't be too bad.

Places to check for updates:

Operators:

  • set_entries()
  • apply()
  • jacobian()

Models:

  • _process_fit_arguments()
  • rhs()
  • jacobian()
  • predict()

@shanemcq18 shanemcq18 linked a pull request May 21, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging a pull request may close this issue.

2 participants