Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple trajectories for identical training parameter values during operator interpolation #72

Open
shanemcq18 opened this issue Nov 13, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@shanemcq18
Copy link
Member

shanemcq18 commented Nov 13, 2024

When using any interpolatory operators, all data corresponding to a fixed training parameter value (even if there are multiple trajectories for different initial conditions or input functions) must be grouped into the same "trajectory", otherwise we are providing multiple values for a single parameter and trying to interpolate (see #71). This should probably be detected and fixed in ParametricROM.fit(), but need to be careful not to mess up fit_regselect_*().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

1 participant