small refactor

Author: StefH

src/WireMock.Net.Abstractions/Handlers/IFileSystemHandler.cs

@@ -1,6 +1,5 @@
 // Copyright © WireMock.Net
 
-using JetBrains.Annotations;
 using System.Collections.Generic;
 
 namespace WireMock.Handlers;
@@ -21,91 +20,91 @@ public interface IFileSystemHandler
     /// </summary>
     /// <param name="path">The path.</param>
     /// <returns>true if path refers to an existing directory; false if the directory does not exist or an error occurs when trying to determine if the specified directory exists.</returns>
-    bool FolderExists([NotNull] string path);
+    bool FolderExists(string path);
 
     /// <summary>
     ///  Creates all directories and subdirectories in the specified path unless they already exist.
     /// </summary>
     /// <param name="path">The path.</param>
-    void CreateFolder([NotNull] string path);
+    void CreateFolder(string path);
 
     /// <summary>
     ///  Returns an enumerable collection of file names in a specified path.
     /// </summary>
     /// <param name="path">The path.</param>
-    /// <param name="includeSubdirectories">A value indicating whether subdirectories should also included when enumerating files.</param>
+    /// <param name="includeSubdirectories">A value indicating whether subdirectories should also be included when enumerating files.</param>
     /// <returns>An enumerable collection of the full names (including paths) for the files in the directory (and optionally subdirectories) specified by path.</returns>
-    IEnumerable<string> EnumerateFiles([NotNull] string path, bool includeSubdirectories);
+    IEnumerable<string> EnumerateFiles(string path, bool includeSubdirectories);
 
     /// <summary>
     /// Read a static mapping file as text.
     /// </summary>
     /// <param name="path">The path (folder + filename with .json extension).</param>
     /// <returns>The file content as text.</returns>
-    string ReadMappingFile([NotNull] string path);
+    string ReadMappingFile(string path);
 
     /// <summary>
     /// Write the static mapping file.
     /// </summary>
     /// <param name="path">The path (folder + filename with .json extension).</param>
     /// <param name="text">The text.</param>
-    void WriteMappingFile([NotNull] string path, [NotNull] string text);
+    void WriteMappingFile(string path, string text);
 
     /// <summary>
     /// Read a response body file as byte[].
     /// </summary>
     /// <param name="path">The path or filename from the file to read.</param>
     /// <returns>The file content as bytes.</returns>
-    byte[] ReadResponseBodyAsFile([NotNull] string path);
+    byte[] ReadResponseBodyAsFile(string path);
 
     /// <summary>
     /// Read a response body file as text.
     /// </summary>
     /// <param name="path">The path or filename from the file to read.</param>
     /// <returns>The file content as text.</returns>
-    string ReadResponseBodyAsString([NotNull] string path);
+    string ReadResponseBodyAsString(string path);
 
     /// <summary>
     /// Delete a file.
     /// </summary>
     /// <param name="filename">The filename.</param>
-    void DeleteFile([NotNull] string filename);
+    void DeleteFile(string filename);
 
     /// <summary>
     /// Determines whether the given path refers to an existing file on disk.
     /// </summary>
     /// <param name="filename">The filename.</param>
     /// <returns>true if path refers to an existing file; false if the file does not exist.</returns>
-    bool FileExists([NotNull] string filename);
+    bool FileExists(string filename);
 
     /// <summary>
     /// Write a file.
     /// </summary>
     /// <param name="filename">The filename.</param>
     /// <param name="bytes">The bytes.</param>
-    void WriteFile([NotNull] string filename, [NotNull] byte[] bytes);
+    void WriteFile(string filename, byte[] bytes);
 
     /// <summary>
     /// Write a file.
     /// </summary>
     /// <param name="folder">The folder.</param>
     /// <param name="filename">The filename.</param>
     /// <param name="bytes">The bytes.</param>
-    void WriteFile([NotNull] string folder, [NotNull] string filename, [NotNull] byte[] bytes);
+    void WriteFile(string folder, string filename, byte[] bytes);
 
     /// <summary>
     /// Read a file as bytes.
     /// </summary>
     /// <param name="filename">The filename.</param>
     /// <returns>The file content as bytes.</returns>
-    byte[] ReadFile([NotNull] string filename);
+    byte[] ReadFile(string filename);
 
     /// <summary>
     /// Read a file as string.
     /// </summary>
     /// <param name="filename">The filename.</param>
     /// <returns>The file content as a string.</returns>
-    string ReadFileAsString([NotNull] string filename);
+    string ReadFileAsString(string filename);
 
     /// <summary>
     /// Gets the folder where the unmatched requests should be stored. For local file system, this would be `{CurrentFolder}/requests/unmatched`.
@@ -114,9 +113,9 @@ public interface IFileSystemHandler
     string GetUnmatchedRequestsFolder();
 
     /// <summary>
-    /// Write a unmatched request to the Unmatched RequestsFolder.
+    /// Write an unmatched request to the Unmatched RequestsFolder.
     /// </summary>
     /// <param name="filename">The filename.</param>
     /// <param name="text">The text.</param>
-    void WriteUnmatchedRequest([NotNull] string filename, [NotNull] string text);
+    void WriteUnmatchedRequest(string filename, string text);
 }

src/WireMock.Net/Json/JObjectExtensions.cs

@@ -1,6 +1,6 @@
 // Copyright © WireMock.Net
 
-// Copied from https://github.com/Handlebars-Net/Handlebars.Net.Helpers/blob/master/src/Handlebars.Net.Helpers.DynamicLinq
+// Copied from https://github.com/Handlebars-Net/Handlebars.Net.Helpers/blob/master/src/Handlebars.Net.Helpers.DynamicLinq which is copied from https://github.com/StefH/JsonConverter
 
 using System;
 using System.Collections;
@@ -14,9 +14,7 @@ namespace WireMock.Json;
 
 internal static class JObjectExtensions
 {
-    private class JTokenResolvers : Dictionary<JTokenType, Func<JToken, DynamicJsonClassOptions?, object?>>
-    {
-    }
+    private class JTokenResolvers : Dictionary<JTokenType, Func<JToken, DynamicJsonClassOptions?, object?>>;
 
     private static readonly JTokenResolvers Resolvers = new()
     {
@@ -180,7 +178,7 @@ private static IEnumerable ConvertJTokenArray(JToken arg, DynamicJsonClassOption
     private static IEnumerable ConvertToTypedArray(IEnumerable<object?> src, Type newType)
     {
         var method = ConvertToTypedArrayGenericMethod.MakeGenericMethod(newType);
-        return (IEnumerable)method.Invoke(null, new object[] { src })!;
+        return (IEnumerable)method.Invoke(null, [src])!;
     }
 
     private static readonly MethodInfo ConvertToTypedArrayGenericMethod = typeof(JObjectExtensions).GetMethod(nameof(ConvertToTypedArrayGeneric), BindingFlags.NonPublic | BindingFlags.Static)!;
@@ -193,7 +191,7 @@ private static T[] ConvertToTypedArrayGeneric<T>(IEnumerable<object> src)
     public static DynamicClass CreateInstance(IList<DynamicPropertyWithValue> dynamicPropertiesWithValue, bool createParameterCtor = true)
     {
         var type = DynamicClassFactory.CreateType(dynamicPropertiesWithValue.Cast<DynamicProperty>().ToArray(), createParameterCtor);
-        var dynamicClass = (DynamicClass)Activator.CreateInstance(type);
+        var dynamicClass = (DynamicClass)Activator.CreateInstance(type)!;
         foreach (var dynamicPropertyWithValue in dynamicPropertiesWithValue.Where(p => p.Value != null))
         {
             dynamicClass.SetDynamicPropertyValue(dynamicPropertyWithValue.Name, dynamicPropertyWithValue.Value!);