FindLogEntries exception 'Destination array was not long enough'

[rinkeb]

Describe the bug

Intermittent exception when calling WireMockServer.FindLogEntries:

Message:

System.ArgumentException : Destination array was not long enough. Check the destination index, length, and the array's lower bounds. (Parameter 'destinationArray')

Stack Trace: 

Array.CopyImpl(Array sourceArray, Int32 sourceIndex, Array destinationArray, Int32 destinationIndex, Int32 length, Boolean reliable)
Array.Copy(Array sourceArray, Int32 sourceIndex, Array destinationArray, Int32 destinationIndex, Int32 length)
List`1.CopyTo(T[] array, Int32 arrayIndex)
Enumerable.ToArray[TSource](IEnumerable`1 source)
WireMockServer.get_LogEntries()
WireMockServer.FindLogEntries(IRequestMatcher[] matchers)

This only seems to happen when log entries are being added to WireMockMiddlewareOptions.LogEntries during the call to FindLogEntries.

Expected behavior:

No exception should be thrown.

Test to reproduce

• Call FindLogEntries while entries are added to source collection _options.LogEntries.

Other related info

It looks like the generic Enumerable.ToArray implementation called in public IReadOnlyList LogEntries => _options.LogEntries.ToArray(); for getting a snapshot of the log entries does not like it when the source collection grows while copying the items. A dedicated threadsafe ToArray implementation on ConcurrentObservableCollection might be the solution.

Related: #1234
Using version 1.7.2

[StefH]

"A dedicated threadsafe ToArray implementation on ConcurrentObservableCollection might be the solution"
--> Good suggestion !

[StefH]

#1256