-
Notifications
You must be signed in to change notification settings - Fork 2
nodePoolName pattern should be customizable #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I see. Can you share what pattern you would like for your specific case? I'm trying to understand if the best way to address this would be to allow configuring the whole pattern, or whether the pattern should be amended (presumably with the UUID pattern)? |
Thanks for picking up on this.
IMO the whole pattern should be configurable. |
Sorry for being late in the game. I am trying to figure out if I have done something wrong with the AWS specific handling that we should modify instead. @TheDoctor028 your PR is it adding custom labeling for AWS specifically or some other cloud provider? If we can the best option would be to just add specific support for each cloud provider. |
The pattern for nodePoolName is currently hardcoded which prevents us from using this tool. Our ASGs doesn't have the "eks-" prefix in their names and renaming them would be a major pain in the a**.
The text was updated successfully, but these errors were encountered: