Skip to content

[XBAP-19700] Update BatchPayments endpoint reponses #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

natdebarbieri
Copy link

@natdebarbieri natdebarbieri commented May 11, 2025

Description

Adds the following fields in the example BatchPayments responses:

  • BatchPayment.Account.CurrencyCode
  • BatchPayment.Payments[].Invoice.CurrencyCode
  • BatchPayment.Payments[].BankAmount

Consumers of the BatchPayments API may receive FX BatchPayments—originating from other parts of Xero—without any way to identify them as such. In coordination with this PR, we are going to be releasing a change to populate the mentioned FX fields in the responses.
This PR updates the example responses to include those FX fields. The fields themselves already exist in the Account, Payment and Invoice objects, so the SDK is already equipped to handle this information.

Release Notes

Adds FX fields to example responses in the BatchPayments endpoints.

Screenshots (if appropriate):

image
image
More in https://xero.atlassian.net/browse/XBAP-21152?focusedCommentId=2518540

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Copy link

PETOSS-748

Copy link

Thanks for raising an issue, a ticket has been created to track your request

@natdebarbieri natdebarbieri marked this pull request as ready for review May 12, 2025 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants