Skip to content

ModuleImpls requires pointer identical netlist for Modules #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
clavin-xlnx opened this issue Dec 2, 2021 · 0 comments
Open

ModuleImpls requires pointer identical netlist for Modules #301

clavin-xlnx opened this issue Dec 2, 2021 · 0 comments

Comments

@clavin-xlnx
Copy link
Member

In

private void checkSameNetlist() {
for (Module mod : this) {
if (mod.getNetlist() != getNetlist()) {
throw new RuntimeException("In the ModuleImpls "+mod.getName()+", the netlists are not pointer-equal");
}
}
}

Any module with the same name will attempt to combine their implementations. This is not a problem except that most often, multiple implementations will come from multiple DCPs and thus will have distinct copies of their netlist---even if they are identical---in memory. Thus, the check cited above will always fail unless the user is aware of manually ensuring the netlist objects are the same. The goal of this issue is to resolve this discrepancy by finding a low friction path for the user to accomplish this, or to provide a more robust (yet efficient) way of checking that two netlists are equivalent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants