Calendar availability incorrect

[orenyk]

This issue relates to the broken calendar view noted below; the issues with renewals were fixed in the #416 branch.

---

While writing tests for renewals for #416 I came across a weird bug. The calendar / Reservations doesn't consider the equipment occupied on the due date, and neither does the renewal code. Steps to replicate:

1. Create reservation from Time.zone.today until Time.zone.today + 1.day (for equipment model with a single equipment item)
2. Check out said reservation
3. Create reservation for same equipment model from Time.zone.today + 2.days until Time.zone.today + 3.days
4. Visit reservation page of first reservation
   • Expected: reservation cannot be renewed
   • Actual: reservation can be "renewed" until due date; clicking the link issues a valid renewal request but nothing changes
5. Visit the equipment model page
   • Expected: equipment has no availability from today until Time.zone.today + 4.days in the calendar
   • Actual: equipment is unavailable today, and for the duration of the upcoming reservation, but is considered available on its due date

This might be resolved in #462, or it might not 😛.

Screenshots

[orenyk]

Note that when I tried to create a reservation starting on the due date I'm pretty sure the cart validation for availability failed... I'd have to double-check though.

[orenyk]

Another note: manually editing the second reservation to start on the due date of the first fixes the calendar issue but not the renewal issue.

[orenyk]

Ok, so I've figured part of this out. The eligible_for_renew? method only checks based on how many times its been renewed and how close it is to the due date, not if there are actually days available to extend the reservation. I'm inclined to add a check to the method for equipment_model.available_count(due_date + 1.day) > 0 and hopefully that will fix things. I'll probably implement this in the #416 branch so I can write those specs.

[orenyk]

Verified - a reservation is no longer eligible_for_renew? if there is no equipment available on the day following its due date. This also prevents the renew method from happening if find_renewal_date simply returns the current due date (which is how it behaves if it can't find an eligible renewal date following the due date). I'll leave this issue open to resolve the JS weirdness.

[orenyk]

I'm not sure this is still an issue but while checking out #1121 I noticed that an overdue reservation will be considered eligible for renewal. I'll investigate in the #416 branch...

[orenyk]

Confirmed, you can renew an overdue reservation. I'm going to make the fix in the #416 branch and focus on the JS weirdness.

[orenyk]

Apparently we had a test specifying that overdue reservations should be eligible for renewal, which makes no sense to me. We'll fix that :-)

[orenyk]

Fixed the JS weirdness, it's always the freaking time zones 😠! Thankfully @squidgetx wrote a dateInTimeZone method that I threw in to keep everything consistent. I believe this is now fixed, opening a PR momentarily.

[squidgetx]

It's a problem with our current system because then those overdue "days" are lost from record, but I don't see a higher level conceptual reason why overdue equipment should be ineligible for renewal. The way a lot of libraries work is that they keep track of how many overdue days a book has. If you renew an overdue book your fine stops increasing, but you still have to pay it.

[orenyk]

And then you'd rely on the other equipment availability / reservation length / renewal validations to restrict the ultimate reservation length? I'm not sure I like that since then you could just remain overdue for a while, and then "renew" at the end to get some extra free days even if it's beyond the usually acceptable length. Someone with an overdue reservation should be encouraged to return it ASAP, not given the option to just keep it. If they want to bring it back and immediately re-reserve it at the counter to end their overdue reservation but keep the equipment that's fine, but I don't think they should be given the option to keep the equipment for free once they've gone past the due date without coming in to the office (it's not like they don't get a reminder e-mail).

[squidgetx]

Ah, you're right. Most library systems have a key "hold" feature that I forgot about that makes this more economical: other patrons can put an item on hold. Then no one can renew it. That itself might be a worthwhile future feature though. For now, we should probably not allow overdue renewals.

[orenyk]

Well that's basically what our "reservations" are, right? 😛