Missed reservations - what do with?

[dgoerger]

Chris pointed out at our last meeting that we currently have a rake task deleting missed reservations at 5am every day, but we still have stats for missed on the user pages and in the Reservations list. This is silly. We can

1. not delete missed reservations and make sure our code is intelligent enough to handle that for double-counting and validations purposes (we should do the latter regardless). downside: list will become very very long with the age of the database.
2. delete missed reservations after some period of time, e.g. a week.
3. continue deleting missed reservations and remove the views on the user profile pages and reservations lists which do not make any sense.

---

• Add setting in app config for missed reservation deletion frequency (see Hide old blackouts #242 for similar behavior with old blackouts)
• remove missed reservation stats from user profile page

[squidgetx]

I vote 2

[dgoerger]

for option 2, we'd just need to make sure to make this behavior clear in the views. the user profile pages stats for missed reservations is probably then also useless and should be removed.

[mnquintana]

I think 2 is the best option.

[orenyk]

Looks like this was never implemented but should be pretty straightforward. I'm moving it to v4.1 and adding a checklist to the issue description.

[orenyk]

Looks like the blackouts_exp_time parameter was missing from strong params... whoops!

[orenyk]

woo testing rake tasks is fun (see here). Once I get them working I'll push and issue a PR.