This repository has been archived by the owner on Jul 24, 2020. It is now read-only.
[1121] view returned overdue #1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we add the late fee somewhere? Maybe on the reservation page so we don't have to complicate the index, or alternatively add an optional column to the table that is only shown with that filter. |
squidgetx
added
1 - working
4 - Needs Review
and removed
4 - Needs Review
1 - working
labels
|
This looks good; one thing that strikes me is that the query on the reservation index page is based on the |
|
I think that's a valid concern but out of scope for this issue |
squidgetx
force-pushed
the
1121_returned_overdue
branch
from
391d172 to
55b2931
Compare
|
Sounds good. Mind updating the commit message to match the CONTRIBUTING guidelines and update the CHANGELOG? Thanks! |
| :requested, :approved_requests, :denied] | ||
| @filters << :missed unless AppConfig.check(:res_exp_time) | ||
| @filters = [:reserved, :checked_out, :overdue, :returned, :returned_overdue, | ||
| :upcoming, :requested, :approved_requests, :denied] |
squidgetx
force-pushed
the
1121_returned_overdue
branch
from
55b2931 to
1fe78a3
Compare
…ndex page. Closes #1121 * Overdue table also shows late fee
squidgetx
force-pushed
the
1121_returned_overdue
branch
from
1fe78a3 to
f013b36
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1121. Allows viewing of returned overdue reservations in the reservations index tabs.