This repository has been archived by the owner on Jul 24, 2020. It is now read-only.
[1227] [v3.4] Fix broken ToS checkbox handling #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suspect that the failing builds are due to time zone issues (e.g. #939), I'll re-run them tomorrow. In the meantime, if someone could review the code itself I can tag / release ASAP and we can request deployment. EDIT Yup, definitely a time zone issue (we're using EDIT And now that it's after midnight EDT the builds pass. So glad we're done with this... |
orenyk
changed the title
|
Looks good! |
|
Merging! |
|
I lied, I'm going to update the CHANGELOG first 😛 |
Resolves #1227
|
Stupid time zone-based failures, I'm merging anyway. |
orenyk
added a commit
that referenced
this pull request
Apr 20, 2015
[1227] [v3.4] Fix broken ToS checkbox handling
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1227 for v3.4.9
Based on change for the
masterbranch (1227_tos_bug) but that PR is pending the merging of #1219.