Skip to content
This repository has been archived by the owner on Jul 24, 2020. It is now read-only.

[1227] [v5.2] Fix broken ToS checkbox handling #1231

Merged
merged 1 commit into from
Apr 24, 2015
Merged

Conversation

orenyk
Copy link
Contributor

@orenyk orenyk commented Apr 20, 2015

Resolves #1227 on release-v5.2

Should be a quick merge based on #1228, but for consistency let's get this looked over.

@orenyk
Copy link
Contributor Author

orenyk commented Apr 20, 2015

Also note that this lacks tests; those will only be merged into master (due to being blocked on #416).

@esoterik
Copy link
Collaborator

I get an error box that complains about improperly checked-off procedures when I haven't accepted the TOS (and that checkbox is unchecked) and am not assigning an equipment item, but the procedures are properly checked off.

@esoterik
Copy link
Collaborator

Also, if the check out fails the TOS is still marked as accepted if it was not accepted previously and the checkbox was ticked. I know I pointed that out before but I'm not sure where I commented on github so I'm going to comment again here.

Found it, it's in the actual issue, though the error still occurs on this branch.

@orenyk
Copy link
Contributor Author

orenyk commented Apr 24, 2015

Ok, the notice is going into the master branch, so I'm merging this.

orenyk added a commit that referenced this pull request Apr 24, 2015
[1227] [v5.2] Fix broken ToS checkbox handling
@orenyk orenyk merged commit 96c7953 into release-v5.2 Apr 24, 2015
@orenyk orenyk deleted the 1227_tos_bug_52 branch October 27, 2015 19:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants