This repository has been archived by the owner on Jul 24, 2020. It is now read-only.
529 deactivated users #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return true # no phone required if no app config | ||
| return true unless AppConfig.first | ||
| return true unless AppConfig.first.require_phone | ||
| return @csv_import |
There was a problem hiding this comment.
why don't we require that a CSV import meet the require_phone option?
There was a problem hiding this comment.
No idea, I'm just refactoring here to match the old behavior. Although that line should probably make sure to return a boolean, eg return !@csv_import.nil?
|
Two inline comments, otherwise this looks great. Nice job! |
This was referenced Jul 17, 2014
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #529 by replacing deactivation by banning and unbanning