Skip to content

Commit 4c7583d

Browse files
committed
Fix for resubmission
Add an URL and an ISBN number to references in DESCRIPTION. Standardize the reference format in documentation.
1 parent 7f44544 commit 4c7583d

File tree

7 files changed

+18
-15
lines changed

7 files changed

+18
-15
lines changed

DESCRIPTION

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ Description: Provides various methods of linear ordering of data. Supports weigh
88
Currently included methods:
99
* Sum of ranks
1010
* Standardized sums
11-
* Hellwig's (Hellwig, 1968)
12-
* TOPSIS (Hwang & Yoon, 1981).
11+
* Hellwig's (Hellwig, 1968, <https://unesdoc.unesco.org/ark:/48223/pf0000158559.locale=en>)
12+
* TOPSIS (Yoon & Hwang, 1981, ISBN:978-3-642-48318-9).
1313
URL: https://github.com/Yard1/linearOrdering
1414
BugReports: https://github.com/Yard1/linearOrdering/issues
1515
License: MIT + file LICENSE

R/linear_ordering_methods.R

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -78,9 +78,7 @@ standardized_sums <- function(decision, weights, impacts) {
7878
#' Should \code{decision} be a data frame, the row names will be carried over
7979
#' to the return value.
8080
#' @author Antoni Baum \email{antoni.baum@protonmail.com}
81-
#' @references Hellwig, Z. (1968). On the optimal choice of predictors.
82-
#' In: Gostkowski, Z. (ed.) Toward a System of Quantitative Indicators of
83-
#' Components of Human Resources Development, Study VI. Paris: UNESCO.
81+
#' @references \href{https://unesdoc.unesco.org/ark:/48223/pf0000158559.locale=en}{Hellwig, Z. (1968). On the optimal choice of predictors. UNESCO.}
8482
#' @examples
8583
#' d <- matrix(rpois(12, 5), nrow = 3, ncol = 3)
8684
#' w <- c(1, 1, 2)
@@ -115,8 +113,9 @@ hellwig <- function(decision, weights, impacts) {
115113
#' Should \code{decision} be a data frame, the row names will be carried over
116114
#' to the return value.
117115
#' @author Antoni Baum \email{antoni.baum@protonmail.com}
118-
#' @references Hwang, C.L.; Yoon, K. (1981). Multiple Attribute Decision
119-
#' Making: Methods and Applications. New York: Springer-Verlag.
116+
#' @references Yoon, K. P., & Hwang, C. L. (1981).
117+
#' Multiple Attribute Decision Making: Methods and Applications.
118+
#' New York: Springer-Verlag. ISBN: 978-3-642-48318-9
120119
#' @examples
121120
#' d <- matrix(rpois(12, 5), nrow = 3, ncol = 3)
122121
#' w <- c(1, 1, 2)

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ Documentation included in the package itself.
2626
Antoni Baum
2727

2828
## References
29-
* Hellwig, Z. (1968). On the optimal choice of predictors. In: Gostkowski, Z. (ed.) Toward a System of Quantitative Indicators of Components of Human Resources Development, Study VI. Paris: UNESCO.
30-
* Hwang, C.L.; Yoon, K. (1981). Multiple Attribute Decision Making: Methods and Applications. New York: Springer-Verlag.
29+
* [Hellwig, Z. (1968). On the optimal choice of predictors. UNESCO.](https://unesdoc.unesco.org/ark:/48223/pf0000158559.locale=en)
30+
* Yoon, K. P., & Hwang, C. L. (1981). Multiple Attribute Decision Making: Methods and Applications. New York: Springer-Verlag. ISBN: 978-3-642-48318-9
3131

3232
## License
33-
[MIT](https://github.com/Yard1/linearOrdering/blob/master/LICENSE)
33+
[MIT](https://github.com/Yard1/linearOrdering/blob/master/LICENSE.md)

cran-comments.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
## Resubmission
22
This is a resubmission. In this version I have:
3+
* Added an URL and an ISBN number to references in DESCRIPTION.
4+
* Standardized the reference format in documentation.
5+
6+
### Previous resubmission:
37
* Fixed the LICENSE file to conform to CRAN requirements.
48
* Fixed a typo in the name of the `standarized_sums` function (and updated DESCRIPTION/README).
59

linearOrdering.Rproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,3 +18,4 @@ StripTrailingWhitespace: Yes
1818
BuildType: Package
1919
PackageUseDevtools: Yes
2020
PackageInstallArgs: --no-multiarch --with-keep.source
21+
PackageRoxygenize: rd,collate,namespace

man/hellwig.Rd

Lines changed: 1 addition & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/topsis.Rd

Lines changed: 3 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)