Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send the jwt token via email to the admin #88

Merged
merged 3 commits into from
Apr 25, 2023

Conversation

Typhlos
Copy link
Contributor

@Typhlos Typhlos commented Nov 17, 2022

Problem

Solution

  • Send the JWT token via email to an admin specified when installing the app

PR Status

  • Code finished and ready to be reviewed/tested
  • The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

@ericgaspar
Copy link
Member

!testme

@yunohost-bot
Copy link
Contributor

😜
Test Badge

@Typhlos
Copy link
Contributor Author

Typhlos commented Nov 21, 2022

For the warning in the linting, it is due to the fact that I use a function that is still not in the official helpers of yunohost but that is supposed to be there in the future : https://github.com/YunoHost-Apps/Experimental_helpers/blob/aa8bd81538dccf46c98fef7eef3f7a4ed2be75ee/ynh_send_readme_to_admin/ynh_send_readme_to_admin__2

As for the failure on upgrade (eca1121), it seems due to the apt upgrade failing. As I haven't changed the upgrade code, I'm not sure if it is due to my changes and if I can do much to fix that.

@Typhlos
Copy link
Contributor Author

Typhlos commented Nov 30, 2022

Hello,

Just wanted to know if there is any update or feedback on my PR. If there is something to change, I'll happily look into it.

@Gredin67 Gredin67 requested a review from zamentur December 19, 2022 15:33
@Gredin67
Copy link
Collaborator

Other options to solve #84 from nextcloud_ynh
YunoHost-Apps/nextcloud_ynh#537

@Gredin67 Gredin67 mentioned this pull request Dec 20, 2022
2 tasks
@Gredin67
Copy link
Collaborator

if we go for this option, we should adapt the README

@Typhlos
Copy link
Contributor Author

Typhlos commented Dec 21, 2022

Indeed, I did not think about updating the README, I'll add an explanation

@ericgaspar
Copy link
Member

!testme

@yunohost-bot
Copy link
Contributor

🌻
Test Badge

@ericgaspar ericgaspar changed the base branch from master to testing April 25, 2023 09:56
@ericgaspar ericgaspar merged commit 7b18db5 into YunoHost-Apps:testing Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants