Merge pull request #122 from Zechiax/fixes

Fix more tests, update README

Author: Zechiax

README.md

@@ -228,7 +228,7 @@ catch (ModrinthApiException e)
 | Change user's avatar                       | PATCH  | ✅           |
 | Get user's projects                        | GET    | ✅           |
 | Get user's followed projects               | GET    | ✅           |
-| Get user's payout history                  | GET    | ✅           |
+| Get user's payout history                  | GET    | ⚠           |
 | Withdraw payout balance to PayPal or Venmo | POST   | ❌           |
 
 ### Threads endpoints

src/Modrinth.Net/Endpoints/Project/IProjectEndpoint.cs

@@ -16,7 +16,7 @@ public interface IProjectEndpoint
     /// <param name="facets">Facets to filter the search by</param>
     /// <param name="index">The sorting method used for sorting search results</param>
     /// <param name="offset">The offset into the search. Skips this number of results</param>
-    /// <param name="limit">The number of results returned by the search</param>
+    /// <param name="limit">The number of results returned by the search. Must be greater than zero</param>
     /// <param name="cancellationToken"> The cancellation token to cancel operation </param>
     /// <returns></returns>
     /// <exception cref="ModrinthApiException"> Thrown when the API returns an error or the request fails </exception>

src/Modrinth.Net/Endpoints/Project/ProjectEndpoint.cs

@@ -224,6 +224,11 @@ public async Task DeleteGalleryImageAsync(string slugOrId, string url,
     public async Task<SearchResponse> SearchAsync(string query, Index index = Index.Downloads, ulong offset = 0,
         ulong limit = 10, FacetCollection? facets = null, CancellationToken cancellationToken = default)
     {
+        if (limit <= 0)
+        {
+            throw new ArgumentOutOfRangeException(nameof(limit), "Limit must be greater than 0");
+        }
+
         var reqMsg = new HttpRequestMessage();
         reqMsg.Method = HttpMethod.Get;
         reqMsg.RequestUri = new Uri("search", UriKind.Relative);

test/Modrinth.Net.Test/ModrinthApiTests/EndpointTests.cs

@@ -28,7 +28,7 @@ public class EndpointTests
     ///     Must be users that have at least one project
     ///     The first ID should be the ID of the user that will be authenticated
     /// </summary>
-    protected readonly string[] TestUserIds = {"MaovZxtD", "5XoMa0C4"};
+    protected readonly string[] TestUserIds = {"JZA4dW8o", "TEZXhE2U"};
 
     protected IModrinthClient Client = null!;
     protected IModrinthClient NoAuthClient = null!;

test/Modrinth.Net.Test/ModrinthApiTests/ProjectColorTests.cs

@@ -25,7 +25,7 @@ public async Task ProjectColor()
     public async Task ProjectColor_WithNoColor()
     {
         // TODO: Don't use a hardcoded project slug
-        var project = await Client.Project.GetAsync("test-project");
+        var project = await Client.Project.GetAsync("nocolorproject");
 
         // Check that the project color is not null
         Assert.That(project.Color, Is.Null);

test/Modrinth.Net.Test/ModrinthApiTests/SearchTests.cs

@@ -33,7 +33,6 @@ public async Task Search_WithFabricSearchTerm_ShouldReturnNonEmptyList()
 
     // Test different limit values
     [Test]
-    [TestCase((ulong) 0)]
     [TestCase((ulong) 1)]
     [TestCase((ulong) 5)]
     [TestCase((ulong) 10)]
@@ -56,6 +55,12 @@ public async Task Search_WithLimit_ShouldReturnLimitedList(ulong limit)
             Assert.That(search.Hits, Is.Not.Empty);
         });
     }
+    
+    [Test]
+    public void Search_WithLimit0_ShouldThrowException()
+    {
+        Assert.ThrowsAsync<ArgumentOutOfRangeException>(async () => await Client.Project.SearchAsync("", limit: 0));
+    }
 
     // Test different offset values
     [Test]
@@ -66,7 +71,7 @@ public async Task Search_WithLimit_ShouldReturnLimitedList(ulong limit)
     public async Task Search_WithOffset_ShouldReturnOffsetList(ulong offset)
     {
         var search = await Client.Project.SearchAsync("", limit: offset + 5);
-        var searchWithOffset = await Client.Project.SearchAsync("", offset: offset, limit: offset + 5);
+        var searchWithOffset = await Client.Project.SearchAsync("", offset: offset, limit: offset);
 
         // Check that the offset list is not the same as the original list
         Assert.That(searchWithOffset.Hits, Is.Not.EqualTo(search.Hits));

test/Modrinth.Net.Test/ModrinthApiTests/UserEndpointTests.cs

@@ -73,12 +73,12 @@ public async Task GetMultipleUsers()
         }
     }
 
-    [Test]
-    public async Task GetCurrentUserPayoutHistory()
-    {
-        var curUser = await Client.User.GetCurrentAsync();
-        var history = await Client.User.GetPayoutHistoryAsync(curUser.Id);
-
-        Assert.That(history, Is.Not.Null);
-    }
+    // [Test]
+    // public async Task GetCurrentUserPayoutHistory()
+    // {
+    //     var curUser = await Client.User.GetCurrentAsync();
+    //     var history = await Client.User.GetPayoutHistoryAsync(curUser.Id);
+    //
+    //     Assert.That(history, Is.Not.Null);
+    // }
 }