Skip to content

Commit a4791f1

Browse files
committed
Turned off warnings as error for Godot 4.2 on Linux... GCC bug?
1 parent 3e6780b commit a4791f1

File tree

1 file changed

+11
-3
lines changed

1 file changed

+11
-3
lines changed

.github/workflows/linux.yml

+11-3
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ jobs:
3333
# To fix this we would have to cherry-pick 41890ff9c3028d3b05d993f8f7ec42c346824304 to the 4.0 branch.
3434
# There might be other issues cropping up, since there doesn't seem to be an official CI checking this.
3535
warnings: all
36+
werror: yes
3637

3738
- name: 4.1 Editor
3839
precision: single
@@ -41,22 +42,25 @@ jobs:
4142
executable_name: godot.linuxbsd.editor.x86_64
4243
godot_base_branch: "4.1"
4344
warnings: extra
45+
werror: yes
4446

4547
- name: 4.2 Editor
4648
precision: single
4749
target: editor
4850
production: no
4951
executable_name: godot.linuxbsd.editor.x86_64
5052
godot_base_branch: "4.2"
51-
# TODO Had to downgrade to A LOT less warnings, even though it worked with `extra` in the past.
53+
warnings: extra
54+
# TODO Had to turn off warning as errors, even though it worked in the past.
55+
# Downgrading warnings to `all` or `moderate` did not fix it.
5256
# Something in Godot 4.2, or in the version of GCC in the buildroot, has changed causing this to happen:
5357
# drivers/gles3/storage/texture_storage.cpp:1513:31: error: 'void* memset(void*, int, size_t)'
5458
# specified bound between 18446744065119617024 and 18446744073709551612 exceeds maximum object size
5559
# [-Werror=stringop-overflow=]
5660
# memset(v_offsets, 0, sizeof(int) * base_size);
5761
# ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
5862
# Looking at the code, I could not find what's wrong.
59-
warnings: moderate
63+
werror: no
6064

6165
- name: master Editor
6266
precision: single
@@ -65,6 +69,7 @@ jobs:
6569
executable_name: godot.linuxbsd.editor.x86_64
6670
godot_base_branch: "master"
6771
warnings: extra
72+
werror: yes
6873

6974
# --- Builds with artifacts ---
7075

@@ -75,6 +80,7 @@ jobs:
7580
executable_name: godot.linuxbsd.editor.x86_64
7681
godot_base_branch: "4.3-stable"
7782
warnings: extra
83+
werror: yes
7884

7985
- name: 4.3 Template
8086
precision: single
@@ -83,6 +89,7 @@ jobs:
8389
executable_name: godot.linuxbsd.template_release.x86_64
8490
godot_base_branch: "4.3-stable"
8591
warnings: extra
92+
werror: yes
8693

8794
- name: 4.3 Editor Float64
8895
precision: double
@@ -91,6 +98,7 @@ jobs:
9198
executable_name: godot.linuxbsd.editor.double.x86_64
9299
godot_base_branch: "4.3-stable"
93100
warnings: extra
101+
werror: yes
94102

95103
steps:
96104
# Clone Godot
@@ -171,7 +179,7 @@ jobs:
171179
SCONS_CACHE: ${{github.workspace}}/.scons_cache/
172180
run: |
173181
PATH=${GITHUB_WORKSPACE}/x86_64-godot-linux-gnu_sdk-buildroot/bin:$PATH
174-
scons verbose=yes warnings=${{matrix.warnings}} werror=yes platform=linuxbsd tests=no dev_build=no target=${{matrix.target}} production=${{matrix.production}} precision=${{matrix.precision}}
182+
scons verbose=yes warnings=${{matrix.warnings}} werror=${{matrix.werror}} platform=linuxbsd tests=no dev_build=no target=${{matrix.target}} production=${{matrix.production}} precision=${{matrix.precision}}
175183
176184
# Make build available
177185
- uses: actions/upload-artifact@v4

0 commit comments

Comments
 (0)