Use new cache_limit SCons parameter.

This is not only to use an up-to-date API: if that limit isn't set,
Godot's build scripts will print something with the character '∞'
(infinite) in it. This unfortunately leads Python to throw an exception
on the Windows CI machine due to incorrect encoding, which in turn
makes the job fail.
I tried to workaround that issue with PYTHONIOENCODING earlier, but for
some reason it didn't have any effect.
See godotengine/godot#103520

Author: Zylann

.github/workflows/linux.yml

@@ -11,7 +11,7 @@ concurrency:
 
 # Global Cache Settings
 env:
-  SCONS_CACHE_LIMIT: 4096
+  SCONS_CACHE_LIMIT_GB: 4
 
 jobs:
   linux:
@@ -185,14 +185,17 @@ jobs:
       # We should always be explicit with our flags usage here since it's gonna be sure to always set those flags
       - name: Compilation
         env:
-          # `SCONS_CACHE` became deprecated since 
+          # `SCONS_CACHE` and `SCONS_CACHE_LIMIT` became deprecated since 
           # https://github.com/godotengine/godot/commit/0e4a4e3c4d602691ce1b4fc6a721c5c637ead57f
           # However since we are also building versions preceding that change, 
-          # we have to keep it in addition to the new parameter
+          # we have to keep them in addition to the new parameters
           SCONS_CACHE: ${{github.workspace}}/.scons_cache/
+          # The new way uses a different unit.
+          # I wish I could do `SCONS_CACHE_LIMIT_GB * 1024` but it isn't documented as an available operator
+          SCONS_CACHE_LIMIT: 4096
         run: |
           PATH=${GITHUB_WORKSPACE}/x86_64-godot-linux-gnu_sdk-buildroot/bin:$PATH
-          scons verbose=yes warnings=${{matrix.warnings}} werror=${{matrix.werror}} platform=linuxbsd tests=no dev_build=no target=${{matrix.target}} production=${{matrix.production}} precision=${{matrix.precision}} "cache_path=${{github.workspace}}/.scons_cache/"
+          scons verbose=yes warnings=${{matrix.warnings}} werror=${{matrix.werror}} platform=linuxbsd tests=no dev_build=no target=${{matrix.target}} production=${{matrix.production}} precision=${{matrix.precision}} "cache_path=${{github.workspace}}/.scons_cache/" cache_limit=${{env.SCONS_CACHE_LIMIT_GB}}
 
       # Make build available
       - uses: actions/upload-artifact@v4

.github/workflows/macos.yml

@@ -11,7 +11,7 @@ concurrency:
 
 # Global Cache Settings
 env:
-  SCONS_CACHE_LIMIT: 4096
+  SCONS_CACHE_LIMIT_GB: 4
 
 jobs:
   build:
@@ -81,7 +81,7 @@ jobs:
       # We should always be explicit with our flags usage here since it's gonna be sure to always set those flags
       - name: Compilation
         run: |
-          scons arch=${{matrix.arch}} verbose=yes warnings=extra werror=yes platform=macos tests=no target=${{matrix.target}} dev_build=no production=yes "cache_path=${{github.workspace}}/.scons_cache/"
+          scons arch=${{matrix.arch}} verbose=yes warnings=extra werror=yes platform=macos tests=no target=${{matrix.target}} dev_build=no production=yes "cache_path=${{github.workspace}}/.scons_cache/" cache_limit=${{env.SCONS_CACHE_LIMIT_GB}}
           
       # Make build available
       - uses: actions/upload-artifact@v4

.github/workflows/mono.yml

@@ -12,7 +12,7 @@ concurrency:
 # Global Cache Settings
 env:
   GODOT_BASE_BRANCH: "4.4-stable"
-  SCONS_CACHE_LIMIT: 4096
+  SCONS_CACHE_LIMIT_GB: 4
 
 jobs:
 
@@ -78,7 +78,7 @@ jobs:
       # We should always be explicit with our flags usage here since it's gonna be sure to always set those flags
       - name: Compile Godot (module_mono_enabled=yes mono_glue=no)
         run: |
-          scons verbose=yes warnings=all werror=yes platform=linuxbsd tests=no target=editor dev_build=no debug_symbols=no module_mono_enabled=yes mono_glue=no copy_mono_root=yes "cache_path=${{github.workspace}}/.scons_cache/"
+          scons verbose=yes warnings=all werror=yes platform=linuxbsd tests=no target=editor dev_build=no debug_symbols=no module_mono_enabled=yes mono_glue=no copy_mono_root=yes "cache_path=${{github.workspace}}/.scons_cache/" cache_limit=${{env.SCONS_CACHE_LIMIT_GB}}
 
       - name: Generate Mono Glue
         run: |
@@ -169,7 +169,7 @@ jobs:
       # We should always be explicit with our flags usage here since it's gonna be sure to always set those flags
       - name: Compilation
         run: |
-          scons verbose=yes warnings=all werror=yes platform=linuxbsd tests=no target=editor dev_build=no debug_symbols=no module_mono_enabled=yes mono_glue=yes mono_static=yes copy_mono_root=yes "cache_path=${{github.workspace}}/.scons_cache/"
+          scons verbose=yes warnings=all werror=yes platform=linuxbsd tests=no target=editor dev_build=no debug_symbols=no module_mono_enabled=yes mono_glue=yes mono_static=yes copy_mono_root=yes "cache_path=${{github.workspace}}/.scons_cache/"  cache_limit=${{env.SCONS_CACHE_LIMIT_GB}}
 
       # Make build available
       - uses: actions/upload-artifact@v4
@@ -255,7 +255,7 @@ jobs:
           SCONS_CACHE_MSVC_CONFIG: true
         run: |
           set PYTHONIOENCODING=utf8
-          scons verbose=yes warnings=all werror=yes platform=windows tests=no target=editor dev_build=no debug_symbols=no module_mono_enabled=yes mono_glue=yes copy_mono_root=yes mono_static=yes "cache_path=${{github.workspace}}/.scons_cache/"
+          scons verbose=yes warnings=all werror=yes platform=windows tests=no target=editor dev_build=no debug_symbols=no module_mono_enabled=yes mono_glue=yes copy_mono_root=yes mono_static=yes "cache_path=${{github.workspace}}/.scons_cache/" cache_limit=${{env.SCONS_CACHE_LIMIT_GB}}
 
       # TODO Enhancement: Run tests? Such tests are able to run from Godot 4.0 only
       # Execute unit tests for the editor

.github/workflows/windows.yml

@@ -14,7 +14,7 @@ concurrency:
 env:
   GODOT_BASE_BRANCH: "4.4-stable"
   SCONS_CACHE_MSVC_CONFIG: true
-  SCONS_CACHE_LIMIT: 4096
+  SCONS_CACHE_LIMIT_GB: 4
 
 jobs:
   windows:
@@ -116,14 +116,19 @@ jobs:
           python modules/voxel/misc/instrument.py -d . -c modules/voxel/misc/instruments.json
 
       # Compile with explicit flags.
-      # `PYTHONIOENCODING` was needed due to certain characters the Godot build system might print (such as '∞'), 
-      # otherwise it makes the job fail with an encoding error.
+      #
+      # TODO `PYTHONIOENCODING` is not working!
+      # It would be needed due to certain characters the Godot build system might print (such as '∞',
+      # when `cache_limit` is not specified), otherwise it makes the job fail with an encoding error.
+      # Currently we specify it, but the issue remain unsolved if it shows up again.
+      # See https://github.com/godotengine/godot/issues/103520
+      #
       # TODO Enhancement: we'd like to use `warnings=extra` with MSVC but Godot doesn't compile yet with that level of warnings.
       # See https://github.com/godotengine/godot/issues/66537
       - name: Compilation
         run: |
           set PYTHONIOENCODING=utf-8
-          scons verbose=yes warnings=all werror=yes platform=windows tests=no target=${{matrix.target}} dev_build=no precision=${{matrix.precision}} tracy=${{matrix.tracy}} production=yes "cache_path=${{github.workspace}}/.scons_cache/"
+          scons verbose=yes warnings=all werror=yes platform=windows tests=no target=${{matrix.target}} dev_build=no precision=${{matrix.precision}} tracy=${{matrix.tracy}} production=yes "cache_path=${{github.workspace}}/.scons_cache/" cache_limit=${{env.SCONS_CACHE_LIMIT_GB}}
 
       - name: "Rename executable"
         if: ${{ matrix.tracy == 'yes' }}